Re: [Qemu-devel] [PATCH v3 3/3] qapi: return a 'missing parameter' error

2016-10-05 Thread Markus Armbruster
The appended fixups are necessary to pass the tests from "[PATCH 2.5/3] tests/test-qmp-input-strict: Cover missing struct members". Can squash in on commit. diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c index 9b9b350..37a8e1f 100644 --- a/qapi/qmp-input-visitor.c +++ b/qapi/qmp

Re: [Qemu-devel] [PATCH v3 3/3] qapi: return a 'missing parameter' error

2016-10-05 Thread Markus Armbruster
Marc-André Lureau writes: > The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing > parameters, but the qapi qmp_dispatch() code uses > QERR_INVALID_PARAMETER_TYPE. > > Improve qapi code to return QERR_MISSING_PARAMETER where > appropriate. > > Fix expected error message in iotest

[Qemu-devel] [PATCH v3 3/3] qapi: return a 'missing parameter' error

2016-09-30 Thread Marc-André Lureau
The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing parameters, but the qapi qmp_dispatch() code uses QERR_INVALID_PARAMETER_TYPE. Improve qapi code to return QERR_MISSING_PARAMETER where appropriate. Fix expected error message in iotests. Signed-off-by: Marc-André Lureau Revi