Re: [Qemu-devel] [PATCH v3 3/5] atapi: GESN: Use structs for commonly-used field types

2011-04-12 Thread Amit Shah
On (Tue) 12 Apr 2011 [15:10:39], Markus Armbruster wrote: > Amit Shah writes: > > > Instead of using magic numbers, use structs that are more descriptive of > > the fields being used. > > > > Signed-off-by: Amit Shah > > --- > > hw/ide/core.c | 22 +- > > 1 files changed,

Re: [Qemu-devel] [PATCH v3 3/5] atapi: GESN: Use structs for commonly-used field types

2011-04-12 Thread Markus Armbruster
Amit Shah writes: > Instead of using magic numbers, use structs that are more descriptive of > the fields being used. > > Signed-off-by: Amit Shah > --- > hw/ide/core.c | 22 +- > 1 files changed, 17 insertions(+), 5 deletions(-) > > diff --git a/hw/ide/core.c b/hw/ide/cor

[Qemu-devel] [PATCH v3 3/5] atapi: GESN: Use structs for commonly-used field types

2011-04-12 Thread Amit Shah
Instead of using magic numbers, use structs that are more descriptive of the fields being used. Signed-off-by: Amit Shah --- hw/ide/core.c | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 5b64676..e838990 100644 --