Re: [Qemu-devel] [PATCH v3 3/5] blkdebug: Simplify override logic

2016-12-07 Thread Kevin Wolf
Am 02.12.2016 um 20:22 hat Eric Blake geschrieben: > Rather than store into a local variable, the copy to the struct > if the value is valid, then reporting errors otherwise, it is > simpler to just store into the struct and report errors if the > value is invalid. This however requires that the

Re: [Qemu-devel] [PATCH v3 3/5] blkdebug: Simplify override logic

2016-12-06 Thread Eric Blake
On 12/06/2016 04:10 PM, Max Reitz wrote: > On 02.12.2016 20:22, Eric Blake wrote: >> Rather than store into a local variable, the copy to the struct >> if the value is valid, then reporting errors otherwise, > > It is rather difficult to part this sentence starting from "the copy". That's

Re: [Qemu-devel] [PATCH v3 3/5] blkdebug: Simplify override logic

2016-12-06 Thread Max Reitz
On 02.12.2016 20:22, Eric Blake wrote: > Rather than store into a local variable, the copy to the struct > if the value is valid, then reporting errors otherwise, It is rather difficult to part this sentence starting from "the copy". > it

[Qemu-devel] [PATCH v3 3/5] blkdebug: Simplify override logic

2016-12-02 Thread Eric Blake
Rather than store into a local variable, the copy to the struct if the value is valid, then reporting errors otherwise, it is simpler to just store into the struct and report errors if the value is invalid. This however requires that the struct store a 64-bit number, rather than a narrower type.