[Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Amit Shah
Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future additions to the code to handle other response types is easier. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 24 +++- 1 files changed, 19 insertions(+), 5

Re: [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 13:43, schrieb Amit Shah: Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future additions to the code to handle other response types is easier. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 24

Re: [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Amit Shah
On (Tue) 12 Apr 2011 [15:09:33], Kevin Wolf wrote: Am 12.04.2011 13:43, schrieb Amit Shah: Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future additions to the code to handle other response types is easier. Signed-off-by: Amit Shah

Re: [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 15:59, schrieb Amit Shah: On (Tue) 12 Apr 2011 [15:09:33], Kevin Wolf wrote: Am 12.04.2011 13:43, schrieb Amit Shah: Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future additions to the code to handle other response types is easier.

Re: [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Amit Shah
On (Tue) 12 Apr 2011 [16:07:23], Kevin Wolf wrote: Am 12.04.2011 15:59, schrieb Amit Shah: On (Tue) 12 Apr 2011 [15:09:33], Kevin Wolf wrote: Am 12.04.2011 13:43, schrieb Amit Shah: Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future

Re: [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Paolo Bonzini
On 04/12/2011 04:12 PM, Amit Shah wrote: gesn_cdb = (void *)packet; +gesn_event_header = (void *)packet; I think this should be buf, not packet. Ah, right. (Though they're the same.) Oh, you're right. I wasn't even aware of that. At some point we should