Re: [Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping

2018-12-19 Thread Adam Williamson
On Wed, 2018-12-19 at 11:17 +, Daniel P. Berrangé wrote: > On Wed, Dec 19, 2018 at 10:42:14AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > This is quite horrible though. I'm more inclined > > > > to revert this patch and find another way to fix the original problem > > > > which won't

Re: [Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping

2018-12-19 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 10:42:14AM +0100, Gerd Hoffmann wrote: > Hi, > > > > This is quite horrible though. I'm more inclined > > > to revert this patch and find another way to fix the original problem > > > which won't require the UI frontends to track modifier state. > > > > The UIs track

Re: [Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping

2018-12-19 Thread Gerd Hoffmann
Hi, > > This is quite horrible though. I'm more inclined > > to revert this patch and find another way to fix the original problem > > which won't require the UI frontends to track modifier state. > > The UIs track modifier state anyway. > > I fact I have some WIP patches to add a generic

Re: [Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping

2018-12-18 Thread Gerd Hoffmann
Hi, > After this patch the two sequences now show: > > 19237@1545158356.679095:vnc_key_event_map down 1, sym 0xffe1 -> keycode > 0x2a [shift] > 19237@1545158356.896528:vnc_key_event_map down 1, sym 0x3c -> keycode 0x33 > [comma] > 19237@1545158356.993672:vnc_key_event_map down 0, sym

Re: [Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping

2018-12-18 Thread Daniel P . Berrangé
On Thu, Feb 22, 2018 at 08:05:13AM +0100, Gerd Hoffmann wrote: > Pass the modifier state to the keymap lookup function. In case multiple > keysym -> keycode mappings exist look at the modifier state and prefer > the mapping where the modifier state matches. > > Signed-off-by: Gerd Hoffmann >

[Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping

2018-02-21 Thread Gerd Hoffmann
Pass the modifier state to the keymap lookup function. In case multiple keysym -> keycode mappings exist look at the modifier state and prefer the mapping where the modifier state matches. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé ---