Re: [Qemu-devel] [PATCH v3 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-31 Thread John Snow
On 08/31/2017 08:27 PM, Philippe Mathieu-Daudé wrote: > On 08/31/2017 09:14 PM, John Snow wrote: >> Signed-off-by: John Snow > > Reviewed-by: Philippe Mathieu-Daudé > TY, and btw the reasoning behind what I went with: Since s->dma_cmd is itself a type

Re: [Qemu-devel] [PATCH v3 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-31 Thread Philippe Mathieu-Daudé
On 08/31/2017 09:14 PM, John Snow wrote: Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- hw/ide/atapi.c| 5 + hw/ide/core.c | 24 +--- hw/ide/trace-events | 3 +++

[Qemu-devel] [PATCH v3 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-31 Thread John Snow
Signed-off-by: John Snow --- hw/ide/atapi.c| 5 + hw/ide/core.c | 24 +--- hw/ide/trace-events | 3 +++ include/hw/ide/internal.h | 6 -- 4 files changed, 25 insertions(+), 13 deletions(-) diff --git a/hw/ide/atapi.c