Re: [Qemu-devel] [PATCH v3 6/9] sm501: Do not clear read only bits when writing registers

2018-06-13 Thread David Gibson
On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > When writing registers that have read only bits we have to avoid > changing these bits as they may have non zero values. Make sure we use > the correct masks to mask out read only and reserved bits when > changing registers. > > Als

[Qemu-devel] [PATCH v3 6/9] sm501: Do not clear read only bits when writing registers

2018-06-13 Thread BALATON Zoltan
When writing registers that have read only bits we have to avoid changing these bits as they may have non zero values. Make sure we use the correct masks to mask out read only and reserved bits when changing registers. Also remove extra spaces from dram_control and arbitration_control assignments.