Re: [Qemu-devel] [PATCH v3 7/9] sm501: Implement i2c part for reading monitor EDID

2018-06-17 Thread David Gibson
On Thu, Jun 14, 2018 at 10:06:33AM +0200, BALATON Zoltan wrote: > On Thu, 14 Jun 2018, David Gibson wrote: > > On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > > > Signed-off-by: BALATON Zoltan > > > > Again needs a commit message expanding on what this is and why it's > > useful

Re: [Qemu-devel] [PATCH v3 7/9] sm501: Implement i2c part for reading monitor EDID

2018-06-14 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan Again needs a commit message expanding on what this is and why it's useful. What else need to be explained apart from that SM501 has an i2c part which is u

Re: [Qemu-devel] [PATCH v3 7/9] sm501: Implement i2c part for reading monitor EDID

2018-06-13 Thread David Gibson
On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan Again needs a commit message expanding on what this is and why it's useful. [snip] > static const VMStateDescription vmstate_sm501_sysbus = { > .name = TYPE_SYSBUS_SM501, > -.version_id = 1,

[Qemu-devel] [PATCH v3 7/9] sm501: Implement i2c part for reading monitor EDID

2018-06-13 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- default-configs/ppc-softmmu.mak| 1 + default-configs/ppcemb-softmmu.mak | 1 + default-configs/sh4-softmmu.mak| 1 + default-configs/sh4eb-softmmu.mak | 1 + hw/display/sm501.c | 136 +++-- 5 files