Re: [Qemu-devel] [PATCH v3 for-2.11 1/3] tpm_emulator: Add a caching layer for the TPM Established flag

2017-12-20 Thread Marc-André Lureau
Hi On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger wrote: > Add a caching layer for the TPM established flag so that we don't > need to go to the emulator every time the flag is read by accessing > the REG_ACCESS register. > > Signed-off-by: Stefan Berger looks good, Reviewed-by: Marc-André Lu

Re: [Qemu-devel] [PATCH v3 for-2.11 1/3] tpm_emulator: Add a caching layer for the TPM Established flag

2017-12-05 Thread Stefan Berger
On 11/15/2017 04:05 AM, Valluri, Amarnath wrote: On Wed, 2017-11-15 at 04:47 +0100, Marc-André Lureau wrote: Hi On Wed, Nov 15, 2017 at 2:16 AM, Stefan Berger wrote: On 11/14/2017 06:40 PM, Marc-André Lureau wrote: Hi On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger wrote: Add a caching

Re: [Qemu-devel] [PATCH v3 for-2.11 1/3] tpm_emulator: Add a caching layer for the TPM Established flag

2017-11-15 Thread Stefan Berger
On 11/14/2017 10:47 PM, Marc-André Lureau wrote: Hi On Wed, Nov 15, 2017 at 2:16 AM, Stefan Berger wrote: On 11/14/2017 06:40 PM, Marc-André Lureau wrote: Hi On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger wrote: Add a caching layer for the TPM established flag so that we don't need to go

Re: [Qemu-devel] [PATCH v3 for-2.11 1/3] tpm_emulator: Add a caching layer for the TPM Established flag

2017-11-15 Thread Valluri, Amarnath
On Wed, 2017-11-15 at 04:47 +0100, Marc-André Lureau wrote: > Hi > > On Wed, Nov 15, 2017 at 2:16 AM, Stefan Berger > wrote: > > > > On 11/14/2017 06:40 PM, Marc-André Lureau wrote: > > > > > > > > > Hi > > > > > > On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger > > > wrote: > > > > > > > >

Re: [Qemu-devel] [PATCH v3 for-2.11 1/3] tpm_emulator: Add a caching layer for the TPM Established flag

2017-11-14 Thread Marc-André Lureau
Hi On Wed, Nov 15, 2017 at 2:16 AM, Stefan Berger wrote: > On 11/14/2017 06:40 PM, Marc-André Lureau wrote: >> >> Hi >> >> On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger >> wrote: >>> >>> Add a caching layer for the TPM established flag so that we don't >>> need to go to the emulator every time

Re: [Qemu-devel] [PATCH v3 for-2.11 1/3] tpm_emulator: Add a caching layer for the TPM Established flag

2017-11-14 Thread Stefan Berger
On 11/14/2017 06:40 PM, Marc-André Lureau wrote: Hi On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger wrote: Add a caching layer for the TPM established flag so that we don't need to go to the emulator every time the flag is read by accessing the REG_ACCESS register. What's the impact? Isn't th

Re: [Qemu-devel] [PATCH v3 for-2.11 1/3] tpm_emulator: Add a caching layer for the TPM Established flag

2017-11-14 Thread Marc-André Lureau
Hi On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger wrote: > Add a caching layer for the TPM established flag so that we don't > need to go to the emulator every time the flag is read by accessing > the REG_ACCESS register. What's the impact? Isn't this just a "small" optimization? Iotw, why is t

[Qemu-devel] [PATCH v3 for-2.11 1/3] tpm_emulator: Add a caching layer for the TPM Established flag

2017-11-14 Thread Stefan Berger
Add a caching layer for the TPM established flag so that we don't need to go to the emulator every time the flag is read by accessing the REG_ACCESS register. Signed-off-by: Stefan Berger v1->v2: - move the caching to the backend layer since detecting the TPM 1.2 TSC_ResetEstablishmentBit()