Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-04 Thread Stefan Hajnoczi
On Wed, Jul 03, 2013 at 03:39:51PM +0800, Qiao Nuohan wrote: On 07/01/2013 07:45 PM, Stefan Hajnoczi wrote: In flatten format, data will be write to dumpfile block by block, and uses the following structure to indicate the offset and size of a data block. struct makedumpfile_data_header {

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-03 Thread Qiao Nuohan
On 07/01/2013 07:45 PM, Stefan Hajnoczi wrote: I'm now convinced that kdump is worthwhile, thanks for providing data. It would be nice to see the flattened kdump approach. Hi Stefan and Luiz, Thanks for Stefan's review again! I am starting to implement the function using flatten format. And

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-01 Thread Stefan Hajnoczi
On Fri, Jun 28, 2013 at 10:57:28AM +0800, Qiao Nuohan wrote: On 06/27/2013 04:54 PM, Stefan Hajnoczi wrote: The interesting question is how effective this approach is. If it's good enough then it would be a fairly simple modification to dump.c. I see, if excluding zero page in ELF can

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-27 Thread Qiao Nuohan
Sorry for replying late. On 06/20/2013 04:57 PM, Stefan Hajnoczi wrote: Please link to the code that writes DISKDUMP kdump files on a physical machine. I only see the crash utility code to read the DISKDUMP code but I haven't found anything in the Linux kernel, the crash utility, or the

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-27 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 03:11:09PM +0800, Qiao Nuohan wrote: You asked about using ELF more efficiently. For implementing *excluding zero* pages, *PT_LOAD* can be made use of. p_memsz and p_filesz fields of PT_LOAD entry are used to describe memory size and the size of corresponding data in

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-27 Thread Qiao Nuohan
On 06/27/2013 04:54 PM, Stefan Hajnoczi wrote: The interesting question is how effective this approach is. If it's good enough then it would be a fairly simple modification to dump.c. I see, if excluding zero page in ELF can make a lot of size reduce, it's better to choose this method. But

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-20 Thread Stefan Hajnoczi
On Thu, Jun 20, 2013 at 10:18:35AM +0800, Qiao Nuohan wrote: On 06/19/2013 09:49 PM, Stefan Hajnoczi wrote: Where does that code live that writes DISKDUMP files? I can see the diskdump.[ch] code. Sorry, I cannot catch what do you mean here. Please link to the code that writes DISKDUMP

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-19 Thread Qiao Nuohan
On 06/14/2013 02:12 AM, Luiz Capitulino wrote: I've started reviewing this, but I'm out of cycles for this week. Hi Luiz, No comments yet? -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-19 Thread Stefan Hajnoczi
On Tue, May 28, 2013 at 10:50:28AM +0800, qiaonuo...@cn.fujitsu.com wrote: The kdump-compressed format is *linux specific* *linux standard* crash dump format used in kdump framework. The kdump-compressed format is readable only with the crash utility, and it can be smaller than the ELF format

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-19 Thread Qiao Nuohan
On 06/19/2013 09:49 PM, Stefan Hajnoczi wrote: Where does that code live that writes DISKDUMP files? I can see the diskdump.[ch] code. Sorry, I cannot catch what do you mean here. The file format is pretty bad: we need 4 temporary files and a lot of data copying to write it out. Why not

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-13 Thread Luiz Capitulino
On Tue, 11 Jun 2013 09:48:40 +0800 Qiao Nuohan qiaonuo...@cn.fujitsu.com wrote: introspection. I just want these patches reviewed first, then I may get these patches ready for merging soon after introspection support. I've started reviewing this, but I'm out of cycles for this week. Can

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-10 Thread Luiz Capitulino
On Mon, 10 Jun 2013 10:15:35 +0800 Qiao Nuohan qiaonuo...@cn.fujitsu.com wrote: On 06/05/2013 10:15 AM, Luiz Capitulino wrote: I can review it until the end of this week. If this series is adding a new argument (which I believe is what it does) then there's only two ways to get this

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-10 Thread Qiao Nuohan
On 06/10/2013 08:54 PM, Luiz Capitulino wrote: On Mon, 10 Jun 2013 10:15:35 +0800 Qiao Nuohanqiaonuo...@cn.fujitsu.com wrote: On 06/05/2013 10:15 AM, Luiz Capitulino wrote: I can review it until the end of this week. If this series is adding a new argument (which I believe is what it does)

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-09 Thread Qiao Nuohan
On 06/05/2013 10:15 AM, Luiz Capitulino wrote: I can review it until the end of this week. If this series is adding a new argument (which I believe is what it does) then there's only two ways to get this merged: either we wait for full introspection or you add this feature as a new command. I'd

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-05 Thread Amos Kong
On Tue, Jun 04, 2013 at 10:15:41PM -0400, Luiz Capitulino wrote: [CC'ing Amos this time] On Wed, 05 Jun 2013 09:29:19 +0800 Qiao Nuohan qiaonuo...@cn.fujitsu.com wrote: I haven't reviewed it yet, but we need introspection support before merging this. Hello Luiz, Is it

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-04 Thread Qiao Nuohan
I haven't reviewed it yet, but we need introspection support before merging this. Hello Luiz, Is it possible to get this reviewed, or I am supposed to wait until introspection support being settled? On 05/28/2013 10:50 AM, qiaonuo...@cn.fujitsu.com wrote: From: Qiao

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-04 Thread Luiz Capitulino
On Wed, 05 Jun 2013 09:29:19 +0800 Qiao Nuohan qiaonuo...@cn.fujitsu.com wrote: I haven't reviewed it yet, but we need introspection support before merging this. Hello Luiz, Is it possible to get this reviewed, or I am supposed to wait until introspection support being settled? I

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-04 Thread Luiz Capitulino
[CC'ing Amos this time] On Wed, 05 Jun 2013 09:29:19 +0800 Qiao Nuohan qiaonuo...@cn.fujitsu.com wrote: I haven't reviewed it yet, but we need introspection support before merging this. Hello Luiz, Is it possible to get this reviewed, or I am supposed to wait until introspection

[Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com Hi, all The last version is here: http://lists.gnu.org/archive/html/qemu-devel/2013-05/msg02280.html Command 'dump-guest-memory' was introduced to dump guest's memory. But the vmcore's format is only elf32 or elf64. The message is here: