Re: [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file

2018-05-29 Thread Alex Williamson
On Tue, 29 May 2018 12:45:28 +0200 Paolo Bonzini wrote: > On 29/05/2018 11:53, Cornelia Huck wrote: > > On Mon, 28 May 2018 21:36:31 -0300 > > Philippe Mathieu-Daudé wrote: > > > >> On 05/28/2018 09:06 PM, Michael S. Tsirkin wrote: > >>> On Mon, May 28, 2018 at 05:48:05PM -0600, Alex

Re: [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file

2018-05-29 Thread Paolo Bonzini
On 29/05/2018 11:53, Cornelia Huck wrote: > On Mon, 28 May 2018 21:36:31 -0300 > Philippe Mathieu-Daudé wrote: > >> On 05/28/2018 09:06 PM, Michael S. Tsirkin wrote: >>> On Mon, May 28, 2018 at 05:48:05PM -0600, Alex Williamson wrote: On Mon, 28 May 2018 20:26:59 -0300 Philippe

Re: [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file

2018-05-29 Thread Cornelia Huck
On Mon, 28 May 2018 21:36:31 -0300 Philippe Mathieu-Daudé wrote: > On 05/28/2018 09:06 PM, Michael S. Tsirkin wrote: > > On Mon, May 28, 2018 at 05:48:05PM -0600, Alex Williamson wrote: > >> On Mon, 28 May 2018 20:26:59 -0300 > >> Philippe Mathieu-Daudé wrote: > >> > >> -ENOCOMMITLOG > >

Re: [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file

2018-05-28 Thread Philippe Mathieu-Daudé
On 05/28/2018 09:06 PM, Michael S. Tsirkin wrote: > On Mon, May 28, 2018 at 05:48:05PM -0600, Alex Williamson wrote: >> On Mon, 28 May 2018 20:26:59 -0300 >> Philippe Mathieu-Daudé wrote: >> >> -ENOCOMMITLOG Oops sorry Alex, I meant to add some, but missed this while rebasing. >> Why? Tangible

Re: [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file

2018-05-28 Thread Michael S. Tsirkin
On Mon, May 28, 2018 at 05:48:05PM -0600, Alex Williamson wrote: > On Mon, 28 May 2018 20:26:59 -0300 > Philippe Mathieu-Daudé wrote: > > -ENOCOMMITLOG > > Why? Tangible benefit. Looks like noise. Thanks, > > Alex I agree it should have a commit log, but .c files should be self-sufficient

Re: [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file

2018-05-28 Thread Alex Williamson
On Mon, 28 May 2018 20:26:59 -0300 Philippe Mathieu-Daudé wrote: -ENOCOMMITLOG Why? Tangible benefit. Looks like noise. Thanks, Alex > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/vfio/vfio-common.h | 1 - > hw/vfio/ccw.c | 1 + > hw/vfio/platform.c

[Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file

2018-05-28 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/vfio/vfio-common.h | 1 - hw/vfio/ccw.c | 1 + hw/vfio/platform.c| 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h index