Re: [Qemu-devel] [PATCH v4 02/15] memory: Access MemoryRegion with MemOp

2019-07-26 Thread Philippe Mathieu-Daudé
On 7/26/19 8:03 AM, tony.ngu...@bt.com wrote: > On 7/25/19 9:45 PM, Philippe Mathieu-Daudé wrote:  >>On 7/25/19 11:52 AM, tony.ngu...@bt.com wrote: >>> Replacing size with size+sign+endianness (MemOp) will enable us to >>> collapse the two byte swaps, adjust_endianness and handle_bswap, along >>>

Re: [Qemu-devel] [PATCH v4 02/15] memory: Access MemoryRegion with MemOp

2019-07-26 Thread tony.nguyen
On 7/25/19 9:45 PM, Philippe Mathieu-Daudé wrote: >On 7/25/19 11:52 AM, tony.ngu...@bt.com wrote: >> Replacing size with size+sign+endianness (MemOp) will enable us to >> collapse the two byte swaps, adjust_endianness and handle_bswap, along >> the I/O path. >> >> While interfaces are converted,

Re: [Qemu-devel] [PATCH v4 02/15] memory: Access MemoryRegion with MemOp

2019-07-25 Thread Philippe Mathieu-Daudé
On 7/25/19 11:52 AM, tony.ngu...@bt.com wrote: > Replacing size with size+sign+endianness (MemOp) will enable us to > collapse the two byte swaps, adjust_endianness and handle_bswap, along > the I/O path. > > While interfaces are converted, callers will have existing unsigned > size coerced into

[Qemu-devel] [PATCH v4 02/15] memory: Access MemoryRegion with MemOp

2019-07-25 Thread tony.nguyen
Replacing size with size+sign+endianness (MemOp) will enable us to collapse the two byte swaps, adjust_endianness and handle_bswap, along the I/O path. While interfaces are converted, callers will have existing unsigned size coerced into a MemOp, and the callee will use this MemOp as an unsigned

[Qemu-devel] [PATCH v4 02/15] memory: Access MemoryRegion with MemOp

2019-07-25 Thread tony.nguyen
Replacing size with size+sign+endianness (MemOp) will enable us to collapse the two byte swaps, adjust_endianness and handle_bswap, along the I/O path. While interfaces are converted, callers will have existing unsigned size coerced into a MemOp, and the callee will use this MemOp as an unsigned