Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-22 Thread Peter Maydell
On 22 December 2011 12:50, Evgeny Voevodin wrote: > Do you mean to use s->gic.cpuiomem[NCPU+1] as in a9mpcore.c a9mp_priv_init() > done? It depends what you want. If you need a memory region which behaves like "CPU interface for whatever the core making this read/write is", that is cpuiomem[0]. I

Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-22 Thread Evgeny Voevodin
On 12/22/2011 04:30 PM, Peter Maydell wrote: On 22 December 2011 07:03, Evgeny Voevodin wrote: Second GIC (external) is represented as "exynos4210.gic" with splitted mapping for CPU (0x1048) and Distributer (0x1049) (we used arm_gic.c availability to split CPU and Distributer memories).

Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-22 Thread Peter Maydell
On 22 December 2011 07:03, Evgeny Voevodin wrote: > Second GIC (external) is represented as "exynos4210.gic" with splitted > mapping for CPU (0x1048) and Distributer (0x1049) (we used > arm_gic.c availability to split CPU and Distributer memories). > > The reason for creation of this devic

Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-21 Thread Evgeny Voevodin
On 12/22/2011 12:31 AM, Peter Maydell wrote: On 21 December 2011 15:08, Evgeny Voevodin wrote: On 12/21/2011 05:50 PM, Peter Maydell wrote: arm_gic.c exposes the CPU and distributor interfaces as their own memory regions now -- you shouldn't need any of this intermediate layer of functions. T

Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-21 Thread Peter Maydell
On 21 December 2011 15:08, Evgeny Voevodin wrote: > On 12/21/2011 05:50 PM, Peter Maydell wrote: >> arm_gic.c exposes the CPU and distributor interfaces as their own >> memory regions now -- you shouldn't need any of this intermediate >> layer of functions. > These functions are not actually for

Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-21 Thread Evgeny Voevodin
On 12/21/2011 05:50 PM, Peter Maydell wrote: On 19 December 2011 11:53, Evgeny Voevodin wrote: +static uint64_t exynos4210_gic_cpu_read(void *opaque, target_phys_addr_t offset, +unsigned size) +{ +Exynos4210GicState *s = (Exynos4210GicState *) opaque; +DPRINTF_EXYNOS4210_GIC("

Re: [Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-21 Thread Peter Maydell
On 19 December 2011 11:53, Evgeny Voevodin wrote: > +static uint64_t exynos4210_gic_cpu_read(void *opaque, target_phys_addr_t > offset, > +        unsigned size) > +{ > +    Exynos4210GicState *s = (Exynos4210GicState *) opaque; > +    DPRINTF_EXYNOS4210_GIC("CPU%d: read offset 0x%x\n", > +    

[Qemu-devel] [PATCH v4 04/11] ARM: exynos4210: IRQ subsystem support.

2011-12-19 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- Makefile.target |3 +- hw/exynos4210.c | 179 - hw/exynos4210.h | 46 hw/exynos4210_combiner.c | 384 ++ hw/exynos4210_gic.c | 509