Re: [Qemu-devel] [PATCH v4 1/2] hw/arm/acpi: simplify AML bit and/or statement

2019-03-08 Thread Heyi Guo
On 2019/3/7 0:34, Igor Mammedov wrote: On Wed, 6 Mar 2019 21:36:56 +0800 Heyi Guo wrote: The last argument of AML bit and/or statement is the target variable, so we don't need to use a NULL target and then an additional store operation; a single bit and/or statement is enough. s: a single

Re: [Qemu-devel] [PATCH v4 1/2] hw/arm/acpi: simplify AML bit and/or statement

2019-03-06 Thread Igor Mammedov
On Wed, 6 Mar 2019 21:36:56 +0800 Heyi Guo wrote: > The last argument of AML bit and/or statement is the target variable, > so we don't need to use a NULL target and then an additional store > operation; a single bit and/or statement is enough. s: a single bit and/or : using just aml_and() or

[Qemu-devel] [PATCH v4 1/2] hw/arm/acpi: simplify AML bit and/or statement

2019-03-06 Thread Heyi Guo
The last argument of AML bit and/or statement is the target variable, so we don't need to use a NULL target and then an additional store operation; a single bit and/or statement is enough. Cc: Shannon Zhao Cc: Peter Maydell Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Suggested-by: Igor