Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-07-05 Thread Igor Mitsyanko
On 07/05/2012 08:44 AM, Peter Crosthwaite wrote: On Tue, Jul 3, 2012 at 9:30 PM, Igor Mitsyanko i.mitsya...@samsung.com wrote: Hi Peter, here's a few review comments for your patch On 06/18/2012 04:42 AM, Peter A. G. Crosthwaite wrote: Device model for Primecell PL330 dma controller.

Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-07-05 Thread Peter Crosthwaite
ACK - Igor, my test vector has no interrupts, Are you able to zip up and send my your exynos test vectorif its touching interrupt behaviour? We only tested DMAC by connecting audio codec model to its peripheral request inputs, this model doesn't use DMAC interrupts either. Ok, Ill get

Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-07-04 Thread Peter Crosthwaite
On Tue, Jul 3, 2012 at 9:30 PM, Igor Mitsyanko i.mitsya...@samsung.com wrote: Hi Peter, here's a few review comments for your patch On 06/18/2012 04:42 AM, Peter A. G. Crosthwaite wrote: Device model for Primecell PL330 dma controller. Signed-off-by: Peter A. G. Crosthwaite

Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-06-19 Thread Peter Crosthwaite
On Tue, Jun 19, 2012 at 12:33 AM, Igor Mitsyanko i.mitsya...@samsung.com wrote: Hi Peter, sorry for not properly reviewing your patch for such a long time, I'll try to do this as soon as possible. Right now I have a few small coments On 06/18/2012 04:42 AM, Peter A. G. Crosthwaite wrote:

Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-06-19 Thread Andreas Färber
Am 19.06.2012 08:40, schrieb Peter Crosthwaite: On Tue, Jun 19, 2012 at 12:33 AM, Igor Mitsyanko i.mitsya...@samsung.com wrote: Hi Peter, sorry for not properly reviewing your patch for such a long time, I'll try to do this as soon as possible. Right now I have a few small coments On

Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-06-19 Thread Peter Maydell
On 19 June 2012 11:17, Andreas Färber afaer...@suse.de wrote: Am 19.06.2012 08:40, schrieb Peter Crosthwaite: On Tue, Jun 19, 2012 at 12:33 AM, Igor Mitsyanko And it still has no save/load support, it is really mandatory for all new devices. I can recall that one of the maintainers wrote a

Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-06-18 Thread Igor Mitsyanko
Hi Peter, sorry for not properly reviewing your patch for such a long time, I'll try to do this as soon as possible. Right now I have a few small coments On 06/18/2012 04:42 AM, Peter A. G. Crosthwaite wrote: Device model for Primecell PL330 dma controller. Signed-off-by: Peter A. G.

[Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-06-17 Thread Peter A. G. Crosthwaite
Device model for Primecell PL330 dma controller. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com Signed-off-by: Kirill Batuzov batuz...@ispras.ru --- changed from v3: rebased against Makefile refactor changed from v2 (in order of diff appearance): GPL version changed to v2