Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-27 Thread Amador Pahim
On Thu, Jul 27, 2017 at 9:39 AM, Amador Pahim wrote: > On Wed, Jul 26, 2017 at 7:35 PM, Stefan Hajnoczi wrote: >> On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote: >>> On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote: >>> > On Mon, Jul 24, 2017 at

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-27 Thread Amador Pahim
On Wed, Jul 26, 2017 at 7:35 PM, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote: >> On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote: >> > On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: >> >> Signed-off-by: Amador Pahim

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-26 Thread Cleber Rosa
On 07/26/2017 01:35 PM, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote: >> On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote: >>> On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: Signed-off-by: Amador Pahim Reviewed-by:

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-26 Thread Stefan Hajnoczi
On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote: > On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote: > > On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: > >> Signed-off-by: Amador Pahim > >> Reviewed-by: Fam Zheng > >> --- > >>

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-25 Thread Cleber Rosa
On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote: > On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: >> Let's make args public so users can extend it without feeling like >> abusing the internal API. > > Nothing is abusing an internal API. PEP8 describes the difference > between

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-25 Thread Amador Pahim
On Tue, Jul 25, 2017 at 3:37 PM, Stefan Hajnoczi wrote: > On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: >> Let's make args public so users can extend it without feeling like >> abusing the internal API. > > Nothing is abusing an internal API. PEP8 describes

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-25 Thread Stefan Hajnoczi
On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: > Let's make args public so users can extend it without feeling like > abusing the internal API. Nothing is abusing an internal API. PEP8 describes the difference between public (no underscore), protected aka subclass API (single

[Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-24 Thread Amador Pahim
Let's make args public so users can extend it without feeling like abusing the internal API. Signed-off-by: Amador Pahim Reviewed-by: Fam Zheng --- scripts/qemu.py | 10 +- tests/qemu-iotests/iotests.py | 18 +- 2 files