Re: [Qemu-devel] [PATCH v4 1/4] block/io: fix copy_range

2018-07-09 Thread Fam Zheng
On Mon, 07/09 17:38, Vladimir Sementsov-Ogievskiy wrote: > 09.07.2018 16:17, Fam Zheng wrote: > > On Mon, 07/09 12:43, Vladimir Sementsov-Ogievskiy wrote: > > > 09.07.2018 04:15, Fam Zheng wrote: > > > > On Fri, 07/06 21:30, Vladimir Sementsov-Ogievskiy wrote: > > > > > Here two things are fixed:

Re: [Qemu-devel] [PATCH v4 1/4] block/io: fix copy_range

2018-07-09 Thread Vladimir Sementsov-Ogievskiy
09.07.2018 16:17, Fam Zheng wrote: On Mon, 07/09 12:43, Vladimir Sementsov-Ogievskiy wrote: 09.07.2018 04:15, Fam Zheng wrote: On Fri, 07/06 21:30, Vladimir Sementsov-Ogievskiy wrote: Here two things are fixed: 1. Architecture On each recursion step, we go to the child of src or dst, only

Re: [Qemu-devel] [PATCH v4 1/4] block/io: fix copy_range

2018-07-09 Thread Fam Zheng
On Mon, 07/09 12:43, Vladimir Sementsov-Ogievskiy wrote: > 09.07.2018 04:15, Fam Zheng wrote: > > On Fri, 07/06 21:30, Vladimir Sementsov-Ogievskiy wrote: > > > Here two things are fixed: > > > > > > 1. Architecture > > > > > > On each recursion step, we go to the child of src or dst, only for

Re: [Qemu-devel] [PATCH v4 1/4] block/io: fix copy_range

2018-07-09 Thread Vladimir Sementsov-Ogievskiy
09.07.2018 04:15, Fam Zheng wrote: On Fri, 07/06 21:30, Vladimir Sementsov-Ogievskiy wrote: Here two things are fixed: 1. Architecture On each recursion step, we go to the child of src or dst, only for one of them. So, it's wrong to create tracked requests for both on each step. It leads to

Re: [Qemu-devel] [PATCH v4 1/4] block/io: fix copy_range

2018-07-08 Thread Fam Zheng
On Fri, 07/06 21:30, Vladimir Sementsov-Ogievskiy wrote: > Here two things are fixed: > > 1. Architecture > > On each recursion step, we go to the child of src or dst, only for one > of them. So, it's wrong to create tracked requests for both on each > step. It leads to tracked requests

[Qemu-devel] [PATCH v4 1/4] block/io: fix copy_range

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
Here two things are fixed: 1. Architecture On each recursion step, we go to the child of src or dst, only for one of them. So, it's wrong to create tracked requests for both on each step. It leads to tracked requests duplication. 2. Wait for serializing requests on write path independently of