Re: [Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-08 Thread Richard Henderson
On 06/08/2016 12:49 PM, Michael Rolnik wrote: Hi Richard. how can I test it? The easiest way is with the "savevm" / "loadvm" monitor commands. It does require that you have a device attached that can create snapshots (e.g. a disk with qcow2 format). While AVR doesn't normally have disks,

Re: [Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-08 Thread Michael Rolnik
Hi Richard. how can I test it? On Tue, Jun 7, 2016 at 5:28 PM, Richard Henderson wrote: > On 06/06/2016 11:32 PM, Michael Rolnik wrote: > > Hi Richard, > > > > /Consider making the vm save state reflect the actual hardware format. > That > > way you can change the qemu

Re: [Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-07 Thread Richard Henderson
On 06/06/2016 11:32 PM, Michael Rolnik wrote: > Hi Richard, > > /Consider making the vm save state reflect the actual hardware format. That > way you can change the qemu internal format while retaining migration > compatibility./ > > How it can be done? how can I modify a value passed to

Re: [Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-07 Thread Michael Rolnik
Hi Richard, *Consider making the vm save state reflect the actual hardware format. That way you can change the qemu internal format while retaining migration compatibility.* How it can be done? how can I modify a value passed to VMSTATE_UINT32? On Mon, Jun 6, 2016 at 11:15 PM, Richard

Re: [Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-06 Thread Peter Maydell
On 6 June 2016 at 11:37, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > --- > arch_init.c | 2 + > configure | 5 + > default-configs/avr-softmmu.mak | 1 + > disas/Makefile.objs | 1 + >

Re: [Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-06 Thread Richard Henderson
On 06/06/2016 03:37 AM, Michael Rolnik wrote: +int print_insn_avr(bfd_vma addr, disassemble_info *info) +{ +int length = 0;; +/* TODO*/ +return length; +} Again, delete this file. This prohibits the default implementation from working. +static void avr_cpu_reset(CPUState

[Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-06 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- arch_init.c | 2 + configure | 5 + default-configs/avr-softmmu.mak | 1 + disas/Makefile.objs | 1 + disas/avr.c | 10 ++ include/disas/bfd.h | 7