Re: [Qemu-devel] [PATCH v4 13/14] memory-device: factor out unplug into hotplug handler

2018-06-04 Thread David Hildenbrand
>> # hw/mem/pc-dimm.c >> mhp_pc_dimm_assigned_slot(int slot) "%d" >> mhp_pc_dimm_assigned_address(uint64_t addr) "0x%"PRIx64 >> +# hw/mem/memory-device.c >> +memory_device_unassign_address(uint64_t addr) "0x%"PRIx64 > maybe split out tracing into a separate patch? Can do, although I think

Re: [Qemu-devel] [PATCH v4 13/14] memory-device: factor out unplug into hotplug handler

2018-06-01 Thread Igor Mammedov
On Thu, 17 May 2018 10:15:26 +0200 David Hildenbrand wrote: > Let's move the unplug logic into the applicable hotplug handler for pc and > spapr. > > We'll move the plug logic next, then this will look more symmetrical in > the hotplug handlers. > > Signed-off-by: David Hildenbrand > --- >

[Qemu-devel] [PATCH v4 13/14] memory-device: factor out unplug into hotplug handler

2018-05-17 Thread David Hildenbrand
Let's move the unplug logic into the applicable hotplug handler for pc and spapr. We'll move the plug logic next, then this will look more symmetrical in the hotplug handlers. Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 17 -