Re: [Qemu-devel] [PATCH v4 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-27 Thread Alex Bennée
Peter Maydell writes: > On 27 February 2018 at 17:52, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> On 02/27/2018 06:38 AM, Alex Bennée wrote: @@ -11244,7 +11245,7 @@ static void

Re: [Qemu-devel] [PATCH v4 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 17:52, Alex Bennée wrote: > > Richard Henderson writes: > >> On 02/27/2018 06:38 AM, Alex Bennée wrote: >>> @@ -11244,7 +11245,7 @@ static void disas_simd_indexed(DisasContext *s, >>> uint32_t insn) >>> } >>>

Re: [Qemu-devel] [PATCH v4 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-27 Thread Alex Bennée
Richard Henderson writes: > On 02/27/2018 06:38 AM, Alex Bennée wrote: >> @@ -11244,7 +11245,7 @@ static void disas_simd_indexed(DisasContext *s, >> uint32_t insn) >> } >> /* fall through */ >> case 0x9: /* FMUL, FMULX */ >> -if

Re: [Qemu-devel] [PATCH v4 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-27 Thread Richard Henderson
On 02/27/2018 06:38 AM, Alex Bennée wrote: > @@ -11244,7 +11245,7 @@ static void disas_simd_indexed(DisasContext *s, > uint32_t insn) > } > /* fall through */ > case 0x9: /* FMUL, FMULX */ > -if (!extract32(size, 1, 1)) { > +if (size == 1) { >

[Qemu-devel] [PATCH v4 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-27 Thread Alex Bennée
The helpers use the new re-factored muladd support in SoftFloat for the float16 work. Signed-off-by: Alex Bennée --- v3 - re-jigged switch statement to fall-through for unalloc - added is_fp16 bool for fpst - fixed up some long lines v4 - don't double-check for