Re: [Qemu-devel] [PATCH v4 2/3] net/rocker: Plug memory leak in pci_rocker_init()

2017-05-19 Thread Markus Armbruster
Mao Zhongyi writes: > pci_rocker_init() leaks a World when the name more than 9 chars, > then return a negative value directly, doesn't make a correct > cleanup. So add a new goto label to fix it. > > Cc: jasow...@redhat.com > Cc: j...@resnulli.us > Cc: f4...@amsat.org

Re: [Qemu-devel] [PATCH v4 2/3] net/rocker: Plug memory leak in pci_rocker_init()

2017-05-18 Thread Mao Zhongyi
Hi, Philippe Thanks for your quick review:) On 05/18/2017 01:22 AM, Philippe Mathieu-Daudé wrote: Hi Mao, On 05/17/2017 08:12 AM, Mao Zhongyi wrote: pci_rocker_init() leaks a World when the name more than 9 chars, then return a negative value directly, doesn't make a correct cleanup. So add a

Re: [Qemu-devel] [PATCH v4 2/3] net/rocker: Plug memory leak in pci_rocker_init()

2017-05-17 Thread Philippe Mathieu-Daudé
Hi Mao, On 05/17/2017 08:12 AM, Mao Zhongyi wrote: pci_rocker_init() leaks a World when the name more than 9 chars, then return a negative value directly, doesn't make a correct cleanup. So add a new goto label to fix it. Cc: jasow...@redhat.com Cc: j...@resnulli.us Cc: f4...@amsat.org Cc:

[Qemu-devel] [PATCH v4 2/3] net/rocker: Plug memory leak in pci_rocker_init()

2017-05-17 Thread Mao Zhongyi
pci_rocker_init() leaks a World when the name more than 9 chars, then return a negative value directly, doesn't make a correct cleanup. So add a new goto label to fix it. Cc: jasow...@redhat.com Cc: j...@resnulli.us Cc: f4...@amsat.org Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi