Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-08-21 Thread Max Reitz
On 2017-08-14 11:07, Markus Armbruster wrote: > Max Reitz writes: > >> On 2017-07-11 13:33, Markus Armbruster wrote: >>> Max Reitz writes: >>> First of all, OK, you don't want QNum(42.0) to equal QNum(42) at all (at least not right now and in the foreseeable future). You're the ma

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-08-14 Thread Markus Armbruster
Max Reitz writes: > On 2017-07-11 13:33, Markus Armbruster wrote: >> Max Reitz writes: >> >>> First of all, OK, you don't want QNum(42.0) to equal QNum(42) at all (at >>> least not right now and in the foreseeable future). >>> You're the maintainer, so you decide, so I'll go along with it. :-)

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-07-11 Thread Max Reitz
On 2017-07-11 13:33, Markus Armbruster wrote: > Max Reitz writes: > >> First of all, OK, you don't want QNum(42.0) to equal QNum(42) at all (at >> least not right now and in the foreseeable future). >> You're the maintainer, so you decide, so I'll go along with it. :-) >> >> Now, let's follow up

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-07-11 Thread Markus Armbruster
Max Reitz writes: > First of all, OK, you don't want QNum(42.0) to equal QNum(42) at all (at > least not right now and in the foreseeable future). > You're the maintainer, so you decide, so I'll go along with it. :-) > > Now, let's follow up with my therefore rather useless commentary: > > (Feel

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-07-10 Thread Max Reitz
First of all, OK, you don't want QNum(42.0) to equal QNum(42) at all (at least not right now and in the foreseeable future). You're the maintainer, so you decide, so I'll go along with it. :-) Now, let's follow up with my therefore rather useless commentary: (Feel free to disregard, because hones

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-07-10 Thread Markus Armbruster
Max Reitz writes: > On 2017-07-06 16:30, Markus Armbruster wrote: >> Max Reitz writes: >> >>> This generic function (along with its implementations for different >>> types) determines whether two QObjects are equal. >>> >>> Signed-off-by: Max Reitz >>> --- >>> Markus also proposed just reporti

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-07-09 Thread Max Reitz
On 2017-07-06 16:30, Markus Armbruster wrote: > Max Reitz writes: > >> This generic function (along with its implementations for different >> types) determines whether two QObjects are equal. >> >> Signed-off-by: Max Reitz >> --- >> Markus also proposed just reporting two values as unequal if th

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-07-09 Thread Max Reitz
On 2017-07-05 21:49, Eric Blake wrote: > On 07/05/2017 02:04 PM, Max Reitz wrote: >> This generic function (along with its implementations for different >> types) determines whether two QObjects are equal. >> >> Signed-off-by: Max Reitz >> --- >> Markus also proposed just reporting two values as u

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-07-06 Thread Markus Armbruster
Max Reitz writes: > This generic function (along with its implementations for different > types) determines whether two QObjects are equal. > > Signed-off-by: Max Reitz > --- > Markus also proposed just reporting two values as unequal if they have a > different internal representation (i.e. a di

Re: [Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-07-05 Thread Eric Blake
On 07/05/2017 02:04 PM, Max Reitz wrote: > This generic function (along with its implementations for different > types) determines whether two QObjects are equal. > > Signed-off-by: Max Reitz > --- > Markus also proposed just reporting two values as unequal if they have a > different internal rep

[Qemu-devel] [PATCH v4 2/5] qapi: Add qobject_is_equal()

2017-07-05 Thread Max Reitz
This generic function (along with its implementations for different types) determines whether two QObjects are equal. Signed-off-by: Max Reitz --- Markus also proposed just reporting two values as unequal if they have a different internal representation (i.e. a different QNum kind). I don't like