Re: [Qemu-devel] [PATCH v4 2/9] target-avr: adding AVR CPU features/flavors

2016-06-08 Thread Richard Henderson
On 06/08/2016 01:53 PM, Michael Rolnik wrote: Richard, do you want to delete all empty lines? Huh? No. Indeed, in this case I want you to add empty lines. r~

Re: [Qemu-devel] [PATCH v4 2/9] target-avr: adding AVR CPU features/flavors

2016-06-08 Thread Michael Rolnik
Richard, do you want to delete all empty lines? On Mon, Jun 6, 2016 at 11:25 PM, Richard Henderson wrote: > On 06/06/2016 03:37 AM, Michael Rolnik wrote: > >> @@ -55,12 +55,14 @@ static void avr_cpu_reset(CPUState *s) >> AVRCPU *cpu = AVR_CPU(s); >> AVRCPUClass *mcc = AVR_CPU_GET_CLASS

Re: [Qemu-devel] [PATCH v4 2/9] target-avr: adding AVR CPU features/flavors

2016-06-06 Thread Richard Henderson
On 06/06/2016 03:37 AM, Michael Rolnik wrote: @@ -55,12 +55,14 @@ static void avr_cpu_reset(CPUState *s) AVRCPU *cpu = AVR_CPU(s); AVRCPUClass *mcc = AVR_CPU_GET_CLASS(cpu); CPUAVRState *env = &cpu->env; +uint32_t features = env->features; mcc->parent_reset(s); mems

[Qemu-devel] [PATCH v4 2/9] target-avr: adding AVR CPU features/flavors

2016-06-06 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu.c | 311 ++- target-avr/cpu.h | 59 +++ 2 files changed, 368 insertions(+), 2 deletions(-) diff --git a/target-avr/cpu.c b/target-avr/cpu.c index cfc1aee..97653c5 100644 --- a/target-avr