Re: [Qemu-devel] [PATCH v4 3/5] megasas: bugfix

2016-04-10 Thread Marcel Apfelbaum
On 04/08/2016 10:16 AM, Markus Armbruster wrote: Please use a more descriptive title. Suggest "megasas: Fix Cao jin writes: msi_init returns non-zero value on both failure and success This is a sentence, should end with a period. Bug's impact? Here's my guess. msi_init() either succeeds

Re: [Qemu-devel] [PATCH v4 3/5] megasas: bugfix

2016-04-09 Thread Cao jin
On 04/08/2016 03:16 PM, Markus Armbruster wrote: Please use a more descriptive title. Suggest "megasas: Fix Cao jin writes: msi_init returns non-zero value on both failure and success This is a sentence, should end with a period. Bug's impact? Here's my guess. msi_init() either succee

Re: [Qemu-devel] [PATCH v4 3/5] megasas: bugfix

2016-04-08 Thread Markus Armbruster
Please use a more descriptive title. Suggest "megasas: Fix Cao jin writes: > msi_init returns non-zero value on both failure and success This is a sentence, should end with a period. Bug's impact? Here's my guess. msi_init() either succeeds and returns 0x50, or fails and returns a negative

[Qemu-devel] [PATCH v4 3/5] megasas: bugfix

2016-04-05 Thread Cao jin
msi_init returns non-zero value on both failure and success Signed-off-by: Cao jin CC: Hannes Reinecke CC: Paolo Bonzini --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index a63a581..56fb645 100644 --- a/hw/scsi/m