Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

2019-01-17 Thread Paolo Bonzini
On 17/01/19 17:13, Stefano Garzarella wrote: > On Thu, Jan 17, 2019 at 04:18:00PM +0100, Paolo Bonzini wrote: >> On 17/01/19 16:05, Stefano Garzarella wrote: That's part of what I didn't quite understand. pc-bios/optionrom/linuxboot.bin (and the other binaries in the 'build-all'

Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

2019-01-17 Thread Stefano Garzarella
On Thu, Jan 17, 2019 at 04:18:00PM +0100, Paolo Bonzini wrote: > On 17/01/19 16:05, Stefano Garzarella wrote: > >> That's part of what I didn't quite understand. > >> pc-bios/optionrom/linuxboot.bin (and the other binaries in the 'build-all' > >> target in pc-bios/optionrom/Makefile) are in

Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

2019-01-17 Thread Paolo Bonzini
On 17/01/19 16:05, Stefano Garzarella wrote: >> That's part of what I didn't quite understand. >> pc-bios/optionrom/linuxboot.bin (and the other binaries in the 'build-all' >> target in pc-bios/optionrom/Makefile) are in .gitignore. >> >> Also, should pvh.bin be added to BLOBS in Makefile like

Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

2019-01-17 Thread Stefano Garzarella
On Thu, Jan 17, 2019 at 02:52:25PM +, Liam Merwick wrote: > > > On 17/01/2019 14:37, Paolo Bonzini wrote: > > On 17/01/19 15:33, Liam Merwick wrote: > > > #    pc-bios/optionrom/pvh.bin > > > #    pc-bios/optionrom/pvh.img > > > #    pc-bios/optionrom/pvh.raw > > > > pvh.bin should not be

Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

2019-01-17 Thread Liam Merwick
On 17/01/2019 14:37, Paolo Bonzini wrote: On 17/01/19 15:33, Liam Merwick wrote: #    pc-bios/optionrom/pvh.bin #    pc-bios/optionrom/pvh.img #    pc-bios/optionrom/pvh.raw pvh.bin should not be ignored. That's part of what I didn't quite understand. pc-bios/optionrom/linuxboot.bin

Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

2019-01-17 Thread Stefano Garzarella
On Thu, Jan 17, 2019 at 03:37:24PM +0100, Paolo Bonzini wrote: > On 17/01/19 15:33, Liam Merwick wrote: > > #    pc-bios/optionrom/pvh.bin > > #    pc-bios/optionrom/pvh.img > > #    pc-bios/optionrom/pvh.raw Thanks Liam! > > pvh.bin should not be ignored. I committed pc-bios/pvh.bin, but I

Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

2019-01-17 Thread Paolo Bonzini
On 17/01/19 15:33, Liam Merwick wrote: > #    pc-bios/optionrom/pvh.bin > #    pc-bios/optionrom/pvh.img > #    pc-bios/optionrom/pvh.raw pvh.bin should not be ignored. Paolo

Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

2019-01-17 Thread Liam Merwick
Hi Stefano, On 17/01/2019 09:02, Stefano Garzarella wrote: If we found initrd through fw_cfg, we can load it and use the first module of hvm_start_info to pass initrd address and size to the kernel. Signed-off-by: Stefano Garzarella --- pc-bios/optionrom/pvh_main.c | 21

Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

2019-01-17 Thread Stefan Hajnoczi
On Thu, Jan 17, 2019 at 10:02:59AM +0100, Stefano Garzarella wrote: > If we found initrd through fw_cfg, we can load it and use the > first module of hvm_start_info to pass initrd address and size > to the kernel. > > Signed-off-by: Stefano Garzarella > --- > pc-bios/optionrom/pvh_main.c | 21

[Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

2019-01-17 Thread Stefano Garzarella
If we found initrd through fw_cfg, we can load it and use the first module of hvm_start_info to pass initrd address and size to the kernel. Signed-off-by: Stefano Garzarella --- pc-bios/optionrom/pvh_main.c | 21 +++-- pc-bios/pvh.bin | Bin 1536 -> 1536 bytes 2