Re: [Qemu-devel] [PATCH v4 5/5] s390x/cpu: Allow hotplug of CPUs

2016-02-18 Thread Igor Mammedov
On Thu, 18 Feb 2016 10:46:52 +0100 David Hildenbrand wrote: > > > #if !defined(CONFIG_USER_ONLY) > > > +void s390_hot_add_cpu(const int64_t id, Error **errp) > > > +{ > > to make it future-proof wrt migration it could be better to > > enforce here that 'id' grows in

Re: [Qemu-devel] [PATCH v4 5/5] s390x/cpu: Allow hotplug of CPUs

2016-02-18 Thread David Hildenbrand
> > #if !defined(CONFIG_USER_ONLY) > > +void s390_hot_add_cpu(const int64_t id, Error **errp) > > +{ > to make it future-proof wrt migration it could be better to > enforce here that 'id' grows in +1 steps so user > won't be able create cpus with gaps. That should be already covered by: if

Re: [Qemu-devel] [PATCH v4 5/5] s390x/cpu: Allow hotplug of CPUs

2016-02-18 Thread Igor Mammedov
On Wed, 17 Feb 2016 15:12:35 -0500 Matthew Rosato wrote: > Implement cpu hotplug routine and add the machine hook. > > Signed-off-by: Matthew Rosato > --- > hw/s390x/s390-virtio-ccw.c | 1 + > target-s390x/cpu.c | 40

Re: [Qemu-devel] [PATCH v4 5/5] s390x/cpu: Allow hotplug of CPUs

2016-02-18 Thread David Hildenbrand
> Implement cpu hotplug routine and add the machine hook. > > Signed-off-by: Matthew Rosato > --- > hw/s390x/s390-virtio-ccw.c | 1 + > target-s390x/cpu.c | 40 > target-s390x/cpu.h | 1 + > 3 files changed,

[Qemu-devel] [PATCH v4 5/5] s390x/cpu: Allow hotplug of CPUs

2016-02-17 Thread Matthew Rosato
Implement cpu hotplug routine and add the machine hook. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio-ccw.c | 1 + target-s390x/cpu.c | 40 target-s390x/cpu.h | 1 + 3 files changed, 42