Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-02-07 Thread Valentin Rakush
Hi Eduardo, thank you for your explanations. > You don't have to, if you just do object_new() like > qmp_device_list_properties() does. Both ObjectClass::properties > and DeviceClas::props are translated to object instance > properties (Object::properties). I should foresee these. Qemu has the

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-02-02 Thread Eduardo Habkost
On Sun, Jan 31, 2016 at 04:40:54PM +0300, Valentin Rakush wrote: > Hi Eduardo, > > I will try to answer some of your questions at this email and will answer > other questions later. > > > Can you clarify what you mean by "TYPE_DEVICE has its own > > properties"? TYPE_DEVICE properties are

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-31 Thread Valentin Rakush
Hi Eduardo, I will try to answer some of your questions at this email and will answer other questions later. > Can you clarify what you mean by "TYPE_DEVICE has its own > properties"? TYPE_DEVICE properties are registered as normal QOM > properties. It is possible that I do not understand

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-29 Thread Valentin Rakush
Hi Eduardo, hi Daniel, I checked most of the classes that are used for x86_64 qemu simulation with this command line: x86_64-softmmu/qemu-system-x86_64 -qmp tcp:localhost:,server,nowait -machine pc -cpu core2duo Here are some of the classes that cannot provide properties with

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-29 Thread Eduardo Habkost
On Fri, Jan 29, 2016 at 01:03:38PM +0300, Valentin Rakush wrote: > Hi Eduardo, hi Daniel, > > I checked most of the classes that are used for x86_64 qemu simulation with > this command line: > x86_64-softmmu/qemu-system-x86_64 -qmp tcp:localhost:,server,nowait > -machine pc -cpu core2duo > >

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-27 Thread Daniel P. Berrange
On Wed, Jan 27, 2016 at 01:09:37PM -0200, Eduardo Habkost wrote: > On Tue, Jan 26, 2016 at 10:19:13PM +, Daniel P. Berrange wrote: > > On Tue, Jan 26, 2016 at 03:26:35PM -0200, Eduardo Habkost wrote: > > > On Tue, Jan 26, 2016 at 03:51:21PM +, Daniel P. Berrange wrote: > > > > On Tue, Jan

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-27 Thread Valentin Rakush
Hi all, My five cents... I am checking for possible problems in case we want to use qmp_device_list_properties() for listing all class properties. Here are couple concerns: - for example, we want to list class properties for "pc-q35-2.4-machine" typename. This is not DeviceClass, therefore we

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-27 Thread Eduardo Habkost
On Tue, Jan 26, 2016 at 10:19:13PM +, Daniel P. Berrange wrote: > On Tue, Jan 26, 2016 at 03:26:35PM -0200, Eduardo Habkost wrote: > > On Tue, Jan 26, 2016 at 03:51:21PM +, Daniel P. Berrange wrote: > > > On Tue, Jan 26, 2016 at 01:35:38PM -0200, Eduardo Habkost wrote: > > > > On Mon, Jan

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-26 Thread Eduardo Habkost
On Mon, Jan 25, 2016 at 11:24:47AM +0300, Valentin Rakush wrote: > This patch adds support for qom-type-prop-list command to list object > class properties. A later patch will use this functionality to > implement x86_64-cpu properties. > > Signed-off-by: Valentin Rakush

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-26 Thread Eric Blake
On 01/26/2016 08:35 AM, Eduardo Habkost wrote: > On Mon, Jan 25, 2016 at 11:24:47AM +0300, Valentin Rakush wrote: >> This patch adds support for qom-type-prop-list command to list object >> class properties. A later patch will use this functionality to >> implement x86_64-cpu properties. >> > >

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-26 Thread Daniel P. Berrange
On Tue, Jan 26, 2016 at 01:35:38PM -0200, Eduardo Habkost wrote: > On Mon, Jan 25, 2016 at 11:24:47AM +0300, Valentin Rakush wrote: > > This patch adds support for qom-type-prop-list command to list object > > class properties. A later patch will use this functionality to > > implement x86_64-cpu

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-26 Thread Eduardo Habkost
On Tue, Jan 26, 2016 at 03:51:21PM +, Daniel P. Berrange wrote: > On Tue, Jan 26, 2016 at 01:35:38PM -0200, Eduardo Habkost wrote: > > On Mon, Jan 25, 2016 at 11:24:47AM +0300, Valentin Rakush wrote: > > > This patch adds support for qom-type-prop-list command to list object > > > class

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-26 Thread Daniel P. Berrange
On Tue, Jan 26, 2016 at 03:26:35PM -0200, Eduardo Habkost wrote: > On Tue, Jan 26, 2016 at 03:51:21PM +, Daniel P. Berrange wrote: > > On Tue, Jan 26, 2016 at 01:35:38PM -0200, Eduardo Habkost wrote: > > > On Mon, Jan 25, 2016 at 11:24:47AM +0300, Valentin Rakush wrote: > > > > This patch adds

[Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-25 Thread Valentin Rakush
This patch adds support for qom-type-prop-list command to list object class properties. A later patch will use this functionality to implement x86_64-cpu properties. Signed-off-by: Valentin Rakush Cc: Luiz Capitulino Cc: Eric Blake