Re: [Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative to cntfrq

2019-09-20 Thread Andrew Jeffery
On Wed, 18 Sep 2019, at 04:55, Richard Henderson wrote: > On 9/17/19 12:14 PM, Peter Maydell wrote: > >> +static Property arm_cpu_gt_cntfrq_property = > >> +DEFINE_PROP_UINT64("cntfrq", ARMCPU, gt_cntfrq, > >> + (1000 * 1000 * 1000) / GTIMER_SCALE); > >

Re: [Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative to cntfrq

2019-09-17 Thread Richard Henderson
On 9/17/19 12:14 PM, Peter Maydell wrote: >> +static Property arm_cpu_gt_cntfrq_property = >> +DEFINE_PROP_UINT64("cntfrq", ARMCPU, gt_cntfrq, >> + (1000 * 1000 * 1000) / GTIMER_SCALE); > I think it would be helpful to have a comment saynig what units >

Re: [Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative to cntfrq

2019-09-17 Thread Peter Maydell
On Thu, 12 Sep 2019 at 07:56, Andrew Jeffery wrote: > > Allow machines to configure CNTFRQ via a property if the ARM core > supports the generic timer. This is necessary on e.g. the ASPEED AST2600 > SoC where the generic timer clock is run at 800MHz or above. The default > value for CNTFRQ

[Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative to cntfrq

2019-09-12 Thread Andrew Jeffery
Allow machines to configure CNTFRQ via a property if the ARM core supports the generic timer. This is necessary on e.g. the ASPEED AST2600 SoC where the generic timer clock is run at 800MHz or above. The default value for CNTFRQ remains at 62.50MHz (based on GTIMER_SCALE). CNTFRQ is a