Re: [Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring

2018-01-12 Thread Igor Mammedov
On Thu, 11 Jan 2018 22:13:25 +0200 "Michael S. Tsirkin" wrote: > On Thu, Jan 11, 2018 at 02:05:20PM +0100, Igor Mammedov wrote: > > On Wed, 10 Jan 2018 00:39:02 +0800 > > Jay Zhou wrote: > > > > Jay, > > considering how non trivial touched code is,

Re: [Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring

2018-01-11 Thread Zhoujian (jay)
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Friday, January 12, 2018 3:56 AM > To: Zhoujian (jay) > Cc: Igor Mammedov ; qemu-devel@nongnu.org; Huangweidong > (C) ; wangxin (U)

Re: [Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring

2018-01-11 Thread Michael S. Tsirkin
On Thu, Jan 11, 2018 at 02:05:20PM +0100, Igor Mammedov wrote: > On Wed, 10 Jan 2018 00:39:02 +0800 > Jay Zhou wrote: > > Jay, > considering how non trivial touched code is, would you mind > first adding 'make check' testcases for success/failure paths > that you are

Re: [Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring

2018-01-11 Thread Michael S. Tsirkin
On Thu, Jan 11, 2018 at 01:55:38PM +, Zhoujian (jay) wrote: > Hi Igor, > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: Thursday, January 11, 2018 9:05 PM > > To: Zhoujian (jay) > > Cc: qemu-devel@nongnu.org;

Re: [Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring

2018-01-11 Thread Zhoujian (jay)
Hi Igor, > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Thursday, January 11, 2018 9:05 PM > To: Zhoujian (jay) > Cc: qemu-devel@nongnu.org; m...@redhat.com; Huangweidong (C) > ; wangxin (U)

Re: [Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring

2018-01-11 Thread Igor Mammedov
On Wed, 10 Jan 2018 00:39:02 +0800 Jay Zhou wrote: Jay, considering how non trivial touched code is, would you mind first adding 'make check' testcases for success/failure paths that you are touching? It would help with merging and ensure that future changes to vhost

[Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring

2018-01-09 Thread Jay Zhou
v4 -> v5: Making the followed up device_add to fall back to userspace virtio when netdev_add fails if vhost force flag does not set. Jay Zhou (4): vhost: remove assertion to prevent crash tap: do not close fd if only vhost failed to initialize vhost: fix memslot limit check vhost: