Re: [Qemu-devel] [PATCH v5 04/16] block/commit: refactor commit to use job callbacks

2018-09-07 Thread Max Reitz
On 2018-09-06 15:02, John Snow wrote: > Use the component callbacks; prepare, abort, and clean. > > NB: prepare is only called when the job has not yet failed; > and abort can be called after prepare. > > complete -> prepare -> abort -> clean > complete -> abort -> clean > > During refactor, a

Re: [Qemu-devel] [PATCH v5 04/16] block/commit: refactor commit to use job callbacks

2018-09-06 Thread Jeff Cody
On Thu, Sep 06, 2018 at 09:02:13AM -0400, John Snow wrote: > Use the component callbacks; prepare, abort, and clean. > > NB: prepare is only called when the job has not yet failed; > and abort can be called after prepare. > > complete -> prepare -> abort -> clean > complete -> abort -> clean >

[Qemu-devel] [PATCH v5 04/16] block/commit: refactor commit to use job callbacks

2018-09-06 Thread John Snow
Use the component callbacks; prepare, abort, and clean. NB: prepare is only called when the job has not yet failed; and abort can be called after prepare. complete -> prepare -> abort -> clean complete -> abort -> clean During refactor, a potential problem with bdrv_drop_intermediate was