Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions

2018-07-02 Thread Joe Perches
On Mon, 2018-07-02 at 14:37 +0200, Paolo Bonzini wrote: > On 29/06/2018 23:46, Joe Perches wrote: > > > > ERROR: "foo * bar" should be "foo *bar" > > > > #310: FILE: hw/ppc/ppc440_uc.c:564: > > > > +size = 8 * MiB * sh; > > > > total: 1 errors, 0 warnings, 433 lines chec

Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions

2018-07-02 Thread Paolo Bonzini
On 29/06/2018 23:46, Joe Perches wrote: >>> ERROR: "foo * bar" should be "foo *bar" >>> #310: FILE: hw/ppc/ppc440_uc.c:564: >>> +size = 8 * MiB * sh; >>> total: 1 errors, 0 warnings, 433 lines checked > Does the linux kernel use these? > I don't believe so. > No, I'm n

Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions

2018-06-29 Thread Joe Perches
On Fri, 2018-06-29 at 15:41 -0500, Eric Blake wrote: > On 06/25/2018 07:41 AM, Philippe Mathieu-Daudé wrote: > > Do not match the IEC binary prefix as camelcase typedefs. > > > > This fixes: > > > > ERROR: "foo * bar" should be "foo *bar" > > #310: FILE: hw/ppc/ppc440_uc.c:564: > >

Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions

2018-06-29 Thread Eric Blake
On 06/25/2018 07:41 AM, Philippe Mathieu-Daudé wrote: Do not match the IEC binary prefix as camelcase typedefs. This fixes: ERROR: "foo * bar" should be "foo *bar" #310: FILE: hw/ppc/ppc440_uc.c:564: +size = 8 * MiB * sh; total: 1 errors, 0 warnings, 433 lines checke

[Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
Do not match the IEC binary prefix as camelcase typedefs. This fixes: ERROR: "foo * bar" should be "foo *bar" #310: FILE: hw/ppc/ppc440_uc.c:564: +size = 8 * MiB * sh; total: 1 errors, 0 warnings, 433 lines checked Signed-off-by: Philippe Mathieu-Daudé --- scripts/check