Re: [Qemu-devel] [PATCH v5 05/12] input: convert virtio-input-hid device to keycodemapdb

2017-09-12 Thread Gerd Hoffmann
Hi, > From what I can see the guest OS will read this bitmap when it first > probes the virtio device, and never updates it.  If so, then is it > actually a problem if we don't preserve the same map across save/ > restore/migrate ? virtio-input config space size isn't fixed, instead it'll take

Re: [Qemu-devel] [PATCH v5 05/12] input: convert virtio-input-hid device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
On Tue, Sep 12, 2017 at 01:37:37PM +0100, Daniel P. Berrange wrote: > Replace the keymap_qcode table with automatically generated > tables. > > Missing entries in keymap_qcode now fixed: > > Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK > Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK > Q_KEY_CODE_STOP -

[Qemu-devel] [PATCH v5 05/12] input: convert virtio-input-hid device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the keymap_qcode table with automatically generated tables. Missing entries in keymap_qcode now fixed: Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK Q_KEY_CODE_STOP -> KEY_STOP Q_KEY_CODE_AGAIN -> KEY_AGAIN Q_KEY_CODE_PROPS -> KEY_PROPS Q_KEY_C