Re: [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps-commit() to be NULL

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: Some QMP 'transaction' types don't need to do anything on .commit(). Make .commit() optional just like .abort(). The drive-backup action will take advantage of this, it only needs to cancel the block job on .abort(). Other block job

Re: [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps-commit() to be NULL

2013-06-03 Thread Stefan Hajnoczi
On Thu, May 30, 2013 at 04:57:21PM -0600, Eric Blake wrote: On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: Some QMP 'transaction' types don't need to do anything on .commit(). Make .commit() optional just like .abort(). The drive-backup action will take advantage of this, it only needs

[Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps-commit() to be NULL

2013-05-30 Thread Stefan Hajnoczi
Some QMP 'transaction' types don't need to do anything on .commit(). Make .commit() optional just like .abort(). The drive-backup action will take advantage of this, it only needs to cancel the block job on .abort(). Other block job actions will probably follow the same pattern, so allow

Re: [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps-commit() to be NULL

2013-05-30 Thread Eric Blake
On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: Some QMP 'transaction' types don't need to do anything on .commit(). Make .commit() optional just like .abort(). The drive-backup action will take advantage of this, it only needs to cancel the block job on .abort(). Other block job actions