Re: [Qemu-devel] [PATCH v5 09/13] target/arm: PMU: Add instruction and cycle events

2018-07-17 Thread Peter Maydell
On 22 June 2018 at 21:32, Aaron Lindsay wrote: > The instruction event is only enabled when icount is used, cycles are > always supported. Always defining get_cycle_count (but altering its > behavior depending on CONFIG_USER_ONLY) allows us to remove some > CONFIG_USER_ONLY #defines throughout

[Qemu-devel] [PATCH v5 09/13] target/arm: PMU: Add instruction and cycle events

2018-06-22 Thread Aaron Lindsay
The instruction event is only enabled when icount is used, cycles are always supported. Always defining get_cycle_count (but altering its behavior depending on CONFIG_USER_ONLY) allows us to remove some CONFIG_USER_ONLY #defines throughout the rest of the code. Signed-off-by: Aaron Lindsay ---