Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-08-09 Thread Juan Quintela
Peter Xu wrote: > On Tue, Aug 08, 2017 at 11:19:35AM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Mon, Jul 17, 2017 at 03:42:30PM +0200, Juan Quintela wrote: >> > >> > [...] >> > >> >> int multifd_load_setup(void) >> >> { >> >> int

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-08-09 Thread Peter Xu
On Tue, Aug 08, 2017 at 11:19:35AM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jul 17, 2017 at 03:42:30PM +0200, Juan Quintela wrote: > > > > [...] > > > >> int multifd_load_setup(void) > >> { > >> int thread_count; > >> -uint8_t i; > >> > >> if

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-08-08 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> We create new channels for each new thread created. We only send through > >> them a character to be sure that we are creating the channels in

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We create new channels for each new thread created. We only send through >> them a character to be sure that we are creating the channels in the >> right order. > > That text is out of date

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-08-08 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jul 17, 2017 at 03:42:30PM +0200, Juan Quintela wrote: > > [...] > >> int multifd_load_setup(void) >> { >> int thread_count; >> -uint8_t i; >> >> if (!migrate_use_multifd()) { >> return 0; >> } >> thread_count =

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-07-20 Thread Peter Xu
On Mon, Jul 17, 2017 at 03:42:30PM +0200, Juan Quintela wrote: [...] > int multifd_load_setup(void) > { > int thread_count; > -uint8_t i; > > if (!migrate_use_multifd()) { > return 0; > } > thread_count = migrate_multifd_threads(); > multifd_recv_state =

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-07-19 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We create new channels for each new thread created. We only send through > them a character to be sure that we are creating the channels in the > right order. That text is out of date isn't it? > > Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-07-19 Thread Daniel P. Berrange
On Mon, Jul 17, 2017 at 03:42:30PM +0200, Juan Quintela wrote: > We create new channels for each new thread created. We only send through > them a character to be sure that we are creating the channels in the > right order. > > Signed-off-by: Juan Quintela > > -- > Split

[Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-07-17 Thread Juan Quintela
We create new channels for each new thread created. We only send through them a character to be sure that we are creating the channels in the right order. Signed-off-by: Juan Quintela -- Split SocketArgs into incoming and outgoing args Use UUID's on the initial message, so