Re: [Qemu-devel] [PATCH v5 1/3] spapr: introduce a fixed IRQ number space

2018-07-30 Thread David Gibson
On Mon, Jul 30, 2018 at 11:05:58AM +0200, Cédric Le Goater wrote: > On 07/27/2018 05:56 AM, David Gibson wrote: > > On Thu, Jul 26, 2018 at 03:37:21PM +0200, Cédric Le Goater wrote: > >> This proposal introduces a new IRQ number space layout using static > >> numbers for all devices, depending on

Re: [Qemu-devel] [PATCH v5 1/3] spapr: introduce a fixed IRQ number space

2018-07-30 Thread Cédric Le Goater
On 07/27/2018 05:56 AM, David Gibson wrote: > On Thu, Jul 26, 2018 at 03:37:21PM +0200, Cédric Le Goater wrote: >> This proposal introduces a new IRQ number space layout using static >> numbers for all devices, depending on a device index, and a bitmap >> allocator for the MSI IRQ numbers which

Re: [Qemu-devel] [PATCH v5 1/3] spapr: introduce a fixed IRQ number space

2018-07-27 Thread Cédric Le Goater
>> +/* >> + * Other VIO devices register values, when allocated by >> + * livirt, are mapped in range [0x00 - 0xef]. >> + */ >> +irq = (reg >> 12) & 0xef; > > This mask doesn't do what you intend - it will map 0x10 to 0, for oops. yes indeed. > example.

Re: [Qemu-devel] [PATCH v5 1/3] spapr: introduce a fixed IRQ number space

2018-07-26 Thread David Gibson
On Thu, Jul 26, 2018 at 03:37:21PM +0200, Cédric Le Goater wrote: > This proposal introduces a new IRQ number space layout using static > numbers for all devices, depending on a device index, and a bitmap > allocator for the MSI IRQ numbers which are negotiated by the guest at > runtime. > > As

[Qemu-devel] [PATCH v5 1/3] spapr: introduce a fixed IRQ number space

2018-07-26 Thread Cédric Le Goater
This proposal introduces a new IRQ number space layout using static numbers for all devices, depending on a device index, and a bitmap allocator for the MSI IRQ numbers which are negotiated by the guest at runtime. As the VIO device model does not have a device index but a "reg" property, we