Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 04:17:25PM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, Mar 23, 2016 at 01:21:52PM +0100, Markus Armbruster wrote: > >> Can you tell me what a management application is supposed to do with the > >> information returned by

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Markus Armbruster
Peter Xu writes: > On Wed, Mar 23, 2016 at 01:21:52PM +0100, Markus Armbruster wrote: >> Can you tell me what a management application is supposed to do with the >> information returned by query-gic-capabilities? Not just in general >> terms, like "using this information,

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 01:21:52PM +0100, Markus Armbruster wrote: > Can you tell me what a management application is supposed to do with the > information returned by query-gic-capabilities? Not just in general > terms, like "using this information, libvirt can warn the user during >

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Markus Armbruster
Peter Xu writes: > On Wed, Mar 23, 2016 at 10:33:09AM +0100, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Tue, Mar 22, 2016 at 07:41:17PM +0100, Markus Armbruster wrote: >> >> Markus Armbruster writes: >> >> >> +## >> >> >>

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 10:44:04AM +0100, Markus Armbruster wrote: > Depends. > > The general rule is to keep separate things separate, and patches > self-contained. The narrow sense of self-contained is each patch > compiles and works. The wider sense is each patch makes sense to its > readers

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 10:33:09AM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > On Tue, Mar 22, 2016 at 07:41:17PM +0100, Markus Armbruster wrote: > >> Markus Armbruster writes: > >> >> +## > >> >> +# @GICCapability: > >> >> +# > >> >> +# This

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Markus Armbruster
Peter Xu writes: > On Tue, Mar 22, 2016 at 12:32:28PM -0600, Eric Blake wrote: >> On 03/17/2016 09:27 PM, Peter Xu wrote: >> > +## >> > +# @GICCapability: >> > +# >> > +# This struct describes capability for a specific GIC version. These >> >> Might be nice to spell out what

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Markus Armbruster
Peter Xu writes: > On Tue, Mar 22, 2016 at 07:41:17PM +0100, Markus Armbruster wrote: >> Markus Armbruster writes: >> >> +## >> >> +# @GICCapability: >> >> +# >> >> +# This struct describes capability for a specific GIC version. These >> >> +# bits are not

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-22 Thread Peter Xu
On Tue, Mar 22, 2016 at 12:32:28PM -0600, Eric Blake wrote: > On 03/17/2016 09:27 PM, Peter Xu wrote: > > +## > > +# @GICCapability: > > +# > > +# This struct describes capability for a specific GIC version. These > > Might be nice to spell out what the acronym GIC means, but that's cosmetic.

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-22 Thread Peter Xu
On Tue, Mar 22, 2016 at 07:41:17PM +0100, Markus Armbruster wrote: > Markus Armbruster writes: > >> +## > >> +# @GICCapability: > >> +# > >> +# This struct describes capability for a specific GIC version. These > >> +# bits are not only decided by QEMU/KVM software version, but

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-22 Thread Markus Armbruster
Markus Armbruster writes: > Peter Xu writes: > >> Define new struct to describe whether we support specific GIC version. >> >> Signed-off-by: Peter Xu >> --- >> qapi-schema.json | 22 ++ >> 1 file changed, 22

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-22 Thread Eric Blake
On 03/17/2016 09:27 PM, Peter Xu wrote: > Define new struct to describe whether we support specific GIC version. > > Signed-off-by: Peter Xu > --- > qapi-schema.json | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/qapi-schema.json

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-22 Thread Markus Armbruster
Peter Xu writes: > Define new struct to describe whether we support specific GIC version. > > Signed-off-by: Peter Xu > --- > qapi-schema.json | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/qapi-schema.json

[Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-19 Thread Peter Xu
Define new struct to describe whether we support specific GIC version. Signed-off-by: Peter Xu --- qapi-schema.json | 22 ++ 1 file changed, 22 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index f253a37..da9671a 100644 ---