Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-09 Thread Peter Xu
On Wed, Aug 09, 2017 at 10:05:19AM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Tue, Aug 08, 2017 at 06:06:04PM +0200, Juan Quintela wrote: > >> Peter Xu wrote: > >> > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: > >> > > >> > [...]

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-09 Thread Juan Quintela
Peter Xu wrote: > On Tue, Aug 08, 2017 at 06:06:04PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: >> > >> > [...] >> > >> >> static int multifd_send_page(uint8_t *address) >> >> { >> >>

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-09 Thread Peter Xu
On Tue, Aug 08, 2017 at 06:06:04PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: > > > > [...] > > > >> static int multifd_send_page(uint8_t *address) > >> { > >> -int i; > >> +int i, j; > >>

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-08 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: > > [...] > >> static int multifd_send_page(uint8_t *address) >> { >> -int i; >> +int i, j; >> MultiFDSendParams *p = NULL; /* make happy gcc */ >> +static multifd_pages_t pages;

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We now send several pages at a time each time that we wakeup a thread. >> >> Signed-off-by: Juan Quintela >> >> -- >> >> Use iovec's insead of creating the equivalent.

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-08 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: >> We now send several pages at a time each time that we wakeup a thread. >> >> Signed-off-by: Juan Quintela >> >> -- >> >> Use iovec's insead of creating the

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-07-20 Thread Peter Xu
On Thu, Jul 20, 2017 at 05:49:47PM +0800, Peter Xu wrote: > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: > > [...] > > > static int multifd_send_page(uint8_t *address) > > { > > -int i; > > +int i, j; > > MultiFDSendParams *p = NULL; /* make happy gcc */ > > +

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-07-20 Thread Peter Xu
On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: [...] > static int multifd_send_page(uint8_t *address) > { > -int i; > +int i, j; > MultiFDSendParams *p = NULL; /* make happy gcc */ > +static multifd_pages_t pages; > +static bool once; > + > +if (!once)

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-07-20 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We now send several pages at a time each time that we wakeup a thread. > > Signed-off-by: Juan Quintela > > -- > > Use iovec's insead of creating the equivalent. > --- > migration/ram.c | 46

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-07-19 Thread Daniel P. Berrange
On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: > We now send several pages at a time each time that we wakeup a thread. > > Signed-off-by: Juan Quintela > > -- > > Use iovec's insead of creating the equivalent. > --- > migration/ram.c | 46

[Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-07-17 Thread Juan Quintela
We now send several pages at a time each time that we wakeup a thread. Signed-off-by: Juan Quintela -- Use iovec's insead of creating the equivalent. --- migration/ram.c | 46 -- 1 file changed, 40 insertions(+), 6 deletions(-)