Re: [Qemu-devel] [PATCH v5 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-04-24 Thread Daniel P. Berrange
On Tue, Feb 21, 2017 at 02:30:10PM +0100, Alberto Garcia wrote: > On Tue 21 Feb 2017 12:55:05 PM CET, Daniel P. Berrange wrote: > > +switch (s->crypt_method_header) { > > +case QCOW_CRYPT_NONE: > > +break; > > + > > +case QCOW_CRYPT_AES: > > +r->crypto_opts =

Re: [Qemu-devel] [PATCH v5 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-02-21 Thread Alberto Garcia
On Tue 21 Feb 2017 12:55:05 PM CET, Daniel P. Berrange wrote: > +switch (s->crypt_method_header) { > +case QCOW_CRYPT_NONE: > +break; > + > +case QCOW_CRYPT_AES: > +r->crypto_opts = block_crypto_open_opts_init( > +Q_CRYPTO_BLOCK_FORMAT_QCOW, opts, "aes-",

[Qemu-devel] [PATCH v5 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-02-21 Thread Daniel P. Berrange
This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content, using the legacyy QCow2 AES scheme. With this change it is now required to use the QCryptoSecret object for providing passwords, instead of the current block password APIs / interactive prompting.