Re: [Qemu-devel] [PATCH v5 2/3] ACPI: Add APEI GHES Table Generation support

2017-07-16 Thread gengdongjiu
Laszlo, Thanks for the comments. On 2017/7/14 3:41, Laszlo Ersek wrote: snip > > snip > >>> + >>> +error_source_table = (AcpiHardwareErrorSourceTable *)(table_data->data >>> ++ table_data->len - buffer->len); >>> +error_source_table->error_source_count = >>> G

Re: [Qemu-devel] [PATCH v5 2/3] ACPI: Add APEI GHES Table Generation support

2017-07-15 Thread gengdongjiu
Michael, Thanks for the review and comments. > -邮件原件- > 发件人: Michael S. Tsirkin [mailto:m...@redhat.com] > 主题: Re: [PATCH v5 2/3] ACPI: Add APEI GHES Table Generation support > > On Wed, Jul 12, 2017 at 10:08:16AM +0800, Dongjiu Geng wrote: > > This implements APEI GHES Table by passin

Re: [Qemu-devel] [PATCH v5 2/3] ACPI: Add APEI GHES Table Generation support

2017-07-13 Thread Michael S. Tsirkin
On Thu, Jul 13, 2017 at 09:41:03PM +0200, Laszlo Ersek wrote: > >> + > >> +error_source++; > >> +} > >> + > >> +for (i = 0; i < GHES_ACPI_HEST_NOTIFY_RESERVED; i++) { > >> +bios_linker_loader_add_pointer(linker, > >> +GHES_ERRORS_FW_CFG_FILE, sizeof(uint64_t) * i

Re: [Qemu-devel] [PATCH v5 2/3] ACPI: Add APEI GHES Table Generation support

2017-07-13 Thread Laszlo Ersek
On 07/13/17 19:32, Michael S. Tsirkin wrote: > On Wed, Jul 12, 2017 at 10:08:16AM +0800, Dongjiu Geng wrote: snip >> etc/acpi/tables etc/hardware_errors >> == >> +---+ >> +--+

Re: [Qemu-devel] [PATCH v5 2/3] ACPI: Add APEI GHES Table Generation support

2017-07-13 Thread Michael S. Tsirkin
On Wed, Jul 12, 2017 at 10:08:16AM +0800, Dongjiu Geng wrote: > This implements APEI GHES Table by passing the error CPER info > to the guest via a fw_cfg_blob. After a CPER info is recorded, an > SEA(Synchronous External Abort)/SEI(SError Interrupt) exception > will be injected into the guest OS.

[Qemu-devel] [PATCH v5 2/3] ACPI: Add APEI GHES Table Generation support

2017-07-11 Thread Dongjiu Geng
This implements APEI GHES Table by passing the error CPER info to the guest via a fw_cfg_blob. After a CPER info is recorded, an SEA(Synchronous External Abort)/SEI(SError Interrupt) exception will be injected into the guest OS. Below is the table layout, the max number of error soure is 11, which