On 8 May 2013 09:28, Jean-Christophe DUBOIS wrote:
> +/*
> + *if we unset the master mode then it ends the ongoing
> + * transfer if any
> + */
nit: missing space between '*' and if'.
thanks
-- PMM
Hi JC,
All blocker comments are addressed from my reviews. Only a few minor
suggestions below.
On Wed, May 8, 2013 at 6:28 PM, Jean-Christophe DUBOIS
wrote:
> The slave mode is not implemented.
This may be worth a LOG_UNIMP in there somewhere (on detection of
selection or use in
slave mode?)
>
The slave mode is not implemented.
Signed-off-by: Jean-Christophe DUBOIS
---
Changes since v1:
* use QOM cast
* run checkpatch on code
* added restrictin on MemoryRegionOps
* use DeviceClass::realise as init function
Changes since v2:
* use CamelCase for state type
*
