Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-10-09 Thread Michael S. Tsirkin
On Wed, Oct 09, 2013 at 11:27:24AM +0800, liu ping fan wrote: On Mon, Sep 30, 2013 at 11:58 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote: Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto: I was really only talking about q35

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-10-09 Thread Paolo Bonzini
Il 09/10/2013 09:24, Michael S. Tsirkin ha scritto: Sorry, out of office for a long time, and did not keep up with this thread in time. When letting the caller set the intcap, we should consider the compatibility of q35. For pc-q35-1.7 or later, the caller should set the property,

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-10-09 Thread Michael S. Tsirkin
On Wed, Oct 09, 2013 at 09:41:29AM +0200, Paolo Bonzini wrote: Il 09/10/2013 09:24, Michael S. Tsirkin ha scritto: Sorry, out of office for a long time, and did not keep up with this thread in time. When letting the caller set the intcap, we should consider the compatibility of q35.

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-10-09 Thread Paolo Bonzini
Il 09/10/2013 10:01, Michael S. Tsirkin ha scritto: So you're suggesting skipping the mechanism we have for compatibility properties, and instead using a global variable or something like that? That's one option. Or we can use global properties - just set for 1.7 too. That's better.

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-10-08 Thread liu ping fan
On Mon, Sep 30, 2013 at 11:58 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote: Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto: I was really only talking about q35 here. I thought it's ugly that users can control intcap

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread liu ping fan
On Sun, Sep 29, 2013 at 12:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 29, 2013 at 11:49:41AM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 3:56 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Sep 12, 2013 at 11:25:15AM +0800, Liu Ping Fan wrote: On PC, IRQ2/8 can

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 04:02:29PM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 12:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 29, 2013 at 11:49:41AM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 3:56 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Sep

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 11:06, Michael S. Tsirkin ha scritto: On Mon, Sep 30, 2013 at 04:02:29PM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 12:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 29, 2013 at 11:49:41AM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 3:56 AM, Michael

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 11:06:48AM +0200, Paolo Bonzini wrote: Il 30/09/2013 11:06, Michael S. Tsirkin ha scritto: On Mon, Sep 30, 2013 at 04:02:29PM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 12:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 29, 2013 at 11:49:41AM

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto: I was really only talking about q35 here. I thought it's ugly that users can control intcap directly. Can object_set_property be used after qdev_try_create? Yes, after that and before qdev_init. This is how Ping Fan is doing PIIX right now.

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote: Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto: I was really only talking about q35 here. I thought it's ugly that users can control intcap directly. Can object_set_property be used after qdev_try_create? Yes, after

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-28 Thread Michael S. Tsirkin
On Thu, Sep 12, 2013 at 11:25:15AM +0800, Liu Ping Fan wrote: On PC, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23 of ioapic can be dynamically assigned to hpet as guest chooses. (Will enable them after introducing pc 1.6 compat) Signed-off-by: Liu Ping Fan

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-28 Thread liu ping fan
On Sun, Sep 29, 2013 at 3:56 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Sep 12, 2013 at 11:25:15AM +0800, Liu Ping Fan wrote: On PC, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23 of ioapic can be dynamically assigned to hpet as guest chooses. (Will enable them after

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-28 Thread Michael S. Tsirkin
On Sun, Sep 29, 2013 at 11:49:41AM +0800, liu ping fan wrote: On Sun, Sep 29, 2013 at 3:56 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Sep 12, 2013 at 11:25:15AM +0800, Liu Ping Fan wrote: On PC, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23 of ioapic can be dynamically

[Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-11 Thread Liu Ping Fan
On PC, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23 of ioapic can be dynamically assigned to hpet as guest chooses. (Will enable them after introducing pc 1.6 compat) Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/timer/hpet.c | 13 +++-- 1 file changed, 11