Re: [Qemu-devel] [PATCH v5 2/5] iotests: fix remainining tests to work with LUKS

2017-06-01 Thread Daniel P. Berrange
On Wed, May 31, 2017 at 05:33:26PM +0200, Max Reitz wrote: > On 2017-05-09 19:33, Daniel P. Berrange wrote: > > The tests 033, 140, 145 and 157 were all broken > > when run with LUKS, since they did not correctly use > > the required image opts args syntax to specify the > > decryption secret.

Re: [Qemu-devel] [PATCH v5 2/5] iotests: fix remainining tests to work with LUKS

2017-05-31 Thread Max Reitz
On 2017-05-31 17:59, Eric Blake wrote: > On 05/31/2017 10:33 AM, Max Reitz wrote: >> On 2017-05-09 19:33, Daniel P. Berrange wrote: >>> The tests 033, 140, 145 and 157 were all broken >>> when run with LUKS, since they did not correctly use >>> the required image opts args syntax to specify the

Re: [Qemu-devel] [PATCH v5 2/5] iotests: fix remainining tests to work with LUKS

2017-05-31 Thread Eric Blake
On 05/31/2017 10:33 AM, Max Reitz wrote: > On 2017-05-09 19:33, Daniel P. Berrange wrote: >> The tests 033, 140, 145 and 157 were all broken >> when run with LUKS, since they did not correctly use >> the required image opts args syntax to specify the >> decryption secret. Further, the 120 test

Re: [Qemu-devel] [PATCH v5 2/5] iotests: fix remainining tests to work with LUKS

2017-05-31 Thread Max Reitz
On 2017-05-09 19:33, Daniel P. Berrange wrote: > The tests 033, 140, 145 and 157 were all broken > when run with LUKS, since they did not correctly use > the required image opts args syntax to specify the > decryption secret. Further, the 120 test simply does > not make sense to run with luks, as

Re: [Qemu-devel] [PATCH v5 2/5] iotests: fix remainining tests to work with LUKS

2017-05-09 Thread Eric Blake
On 05/09/2017 12:33 PM, Daniel P. Berrange wrote: > The tests 033, 140, 145 and 157 were all broken > when run with LUKS, since they did not correctly use > the required image opts args syntax to specify the > decryption secret. Further, the 120 test simply does > not make sense to run with luks,

[Qemu-devel] [PATCH v5 2/5] iotests: fix remainining tests to work with LUKS

2017-05-09 Thread Daniel P. Berrange
The tests 033, 140, 145 and 157 were all broken when run with LUKS, since they did not correctly use the required image opts args syntax to specify the decryption secret. Further, the 120 test simply does not make sense to run with luks, as the scenario exercised is not relevant. The test 181 was