Re: [Qemu-devel] [PATCH v5 3/5] qmp: refactor duplicate code

2017-06-29 Thread Pradeep Jagadeesh
On 6/21/2017 12:00 PM, Greg Kurz wrote: On Wed, 21 Jun 2017 10:34:42 +0200 Pradeep Jagadeesh wrote: On 6/20/2017 6:05 PM, Greg Kurz wrote: On Mon, 19 Jun 2017 09:11:34 -0400 Pradeep Jagadeesh wrote: This patch factor out the duplicate qmp throttle interface code that was present in both bl

Re: [Qemu-devel] [PATCH v5 3/5] qmp: refactor duplicate code

2017-06-21 Thread Greg Kurz
On Wed, 21 Jun 2017 10:34:42 +0200 Pradeep Jagadeesh wrote: > On 6/20/2017 6:05 PM, Greg Kurz wrote: > > On Mon, 19 Jun 2017 09:11:34 -0400 > > Pradeep Jagadeesh wrote: > > > >> This patch factor out the duplicate qmp throttle interface code > >> that was present in both block and fsdev device

Re: [Qemu-devel] [PATCH v5 3/5] qmp: refactor duplicate code

2017-06-21 Thread Pradeep Jagadeesh
On 6/20/2017 6:05 PM, Greg Kurz wrote: On Mon, 19 Jun 2017 09:11:34 -0400 Pradeep Jagadeesh wrote: This patch factor out the duplicate qmp throttle interface code that was present in both block and fsdev device files. The text is obviously wrong. I don't see any duplicate code below. OK, I

Re: [Qemu-devel] [PATCH v5 3/5] qmp: refactor duplicate code

2017-06-20 Thread Greg Kurz
On Mon, 19 Jun 2017 09:11:34 -0400 Pradeep Jagadeesh wrote: > This patch factor out the duplicate qmp throttle interface code > that was present in both block and fsdev device files. > The text is obviously wrong. I don't see any duplicate code below. It is more something like: let's factor ou

[Qemu-devel] [PATCH v5 3/5] qmp: refactor duplicate code

2017-06-19 Thread Pradeep Jagadeesh
This patch factor out the duplicate qmp throttle interface code that was present in both block and fsdev device files. Signed-off-by: Pradeep Jagadeesh --- blockdev.c | 53 +++- hmp.c | 21 ++- include/qem