Re: [Qemu-devel] [PATCH v5 3/5] virtio-9p: break device if buffers are misconfigured

2017-06-30 Thread Greg Kurz
On Fri, 30 Jun 2017 02:33:22 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 28, 2017 at 10:44:30PM +0200, Greg Kurz wrote: > > The 9P protocol is transport agnostic: if the guest misconfigured the > > buffers, the best we can do is to set the broken flag on the device. > > > >

Re: [Qemu-devel] [PATCH v5 3/5] virtio-9p: break device if buffers are misconfigured

2017-06-29 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 10:44:30PM +0200, Greg Kurz wrote: > The 9P protocol is transport agnostic: if the guest misconfigured the > buffers, the best we can do is to set the broken flag on the device. > > Since virtio_pdu_vmarshal() may be called by several active PDUs, we > check if the

Re: [Qemu-devel] [PATCH v5 3/5] virtio-9p: break device if buffers are misconfigured

2017-06-29 Thread Greg Kurz
On Wed, 28 Jun 2017 22:44:30 +0200 Greg Kurz wrote: > The 9P protocol is transport agnostic: if the guest misconfigured the > buffers, the best we can do is to set the broken flag on the device. > > Since virtio_pdu_vmarshal() may be called by several active PDUs, we > check if

[Qemu-devel] [PATCH v5 3/5] virtio-9p: break device if buffers are misconfigured

2017-06-28 Thread Greg Kurz
The 9P protocol is transport agnostic: if the guest misconfigured the buffers, the best we can do is to set the broken flag on the device. Since virtio_pdu_vmarshal() may be called by several active PDUs, we check if the transport isn't broken already to avoid printing extra error messages.