Re: [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

2018-05-23 Thread Peter Xu
On Wed, May 23, 2018 at 10:39:20AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Fri, May 18, 2018 at 02:27:00PM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > On Thu, May 17, 2018 at 03:03:02PM +0200, Markus Armbruster

Re: [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

2018-05-23 Thread Markus Armbruster
Peter Xu writes: > On Fri, May 18, 2018 at 02:27:00PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Thu, May 17, 2018 at 03:03:02PM +0200, Markus Armbruster wrote: >> > >> > [...] >> > >> >> > @@ -2502,7 +2525,9 @@ int

Re: [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

2018-05-20 Thread Peter Xu
On Fri, May 18, 2018 at 02:27:00PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Thu, May 17, 2018 at 03:03:02PM +0200, Markus Armbruster wrote: > > > > [...] > > > >> > @@ -2502,7 +2525,9 @@ int monitor_fdset_get_fd(int64_t fdset_id, int > >> > flags) > >> >

Re: [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

2018-05-18 Thread Markus Armbruster
Peter Xu writes: > On Thu, May 17, 2018 at 03:03:02PM +0200, Markus Armbruster wrote: > > [...] > >> > @@ -2502,7 +2525,9 @@ int monitor_fdset_get_fd(int64_t fdset_id, int flags) >> > MonFdset *mon_fdset; >> > MonFdsetFd *mon_fdset_fd; >> > int mon_fd_flags; >>

Re: [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

2018-05-18 Thread Peter Xu
On Thu, May 17, 2018 at 03:03:02PM +0200, Markus Armbruster wrote: [...] > > @@ -2502,7 +2525,9 @@ int monitor_fdset_get_fd(int64_t fdset_id, int flags) > > MonFdset *mon_fdset; > > MonFdsetFd *mon_fdset_fd; > > int mon_fd_flags; > > +int ret = -1; > > Suggest not to

Re: [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

2018-05-17 Thread Markus Armbruster
Peter Xu writes: > Similar to previous patch, but introduce a new global big lock for > mon_fdsets. Take it where needed. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Peter Xu > --- > monitor.c | 64

[Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

2018-05-08 Thread Peter Xu
Similar to previous patch, but introduce a new global big lock for mon_fdsets. Take it where needed. Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- monitor.c | 64 +-- 1 file changed, 53