Re: [Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by default

2016-05-12 Thread Eric Blake
On 05/12/2016 09:50 AM, Eric Blake wrote: >> This breaks qemu-iotests 136 for raw. It's pretty obvious that this is a >> test case problem (uses unaligned requests to test error accounting), so >> I'm not dropping the patch, but please do send a follow-up. > > ...which explains why I missed this f

Re: [Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by default

2016-05-12 Thread Eric Blake
On 05/12/2016 08:38 AM, Kevin Wolf wrote: > Am 08.05.2016 um 05:16 hat Eric Blake geschrieben: >> There's no reason to require the user to specify a flag just so >> they can pass in unaligned numbers. Keep 'read -p' and 'write -p' >> as no-ops so that I don't have to hunt down and update all users

Re: [Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by default

2016-05-12 Thread Kevin Wolf
Am 08.05.2016 um 05:16 hat Eric Blake geschrieben: > There's no reason to require the user to specify a flag just so > they can pass in unaligned numbers. Keep 'read -p' and 'write -p' > as no-ops so that I don't have to hunt down and update all users > of qemu-io, but otherwise make their behavio

Re: [Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by default

2016-05-09 Thread Max Reitz
On 08.05.2016 05:16, Eric Blake wrote: > There's no reason to require the user to specify a flag just so > they can pass in unaligned numbers. Keep 'read -p' and 'write -p' > as no-ops so that I don't have to hunt down and update all users > of qemu-io, but otherwise make their behavior default as

[Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by default

2016-05-07 Thread Eric Blake
There's no reason to require the user to specify a flag just so they can pass in unaligned numbers. Keep 'read -p' and 'write -p' as no-ops so that I don't have to hunt down and update all users of qemu-io, but otherwise make their behavior default as 'read' and 'write'. Also fix 'write -z', 'rea