Re: [Qemu-devel] [PATCH v5 5/5] qcow2-refcount: don't mask corruptions under internal errors

2019-03-29 Thread Max Reitz
On 20.03.19 18:26, John Snow wrote: > > > On 2/27/19 8:18 AM, Max Reitz wrote: >> On 27.02.19 14:14, Vladimir Sementsov-Ogievskiy wrote: >>> No reasons for not reporting found corruptions as corruptions in case >>> of some internal errors, especially in case of just failed to fix l2 >>> entry

Re: [Qemu-devel] [PATCH v5 5/5] qcow2-refcount: don't mask corruptions under internal errors

2019-03-20 Thread John Snow
On 2/27/19 8:18 AM, Max Reitz wrote: > On 27.02.19 14:14, Vladimir Sementsov-Ogievskiy wrote: >> No reasons for not reporting found corruptions as corruptions in case >> of some internal errors, especially in case of just failed to fix l2 >> entry (and in this case, missed corruptions may

[Qemu-devel] [PATCH v5 5/5] qcow2-refcount: don't mask corruptions under internal errors

2019-02-27 Thread Vladimir Sementsov-Ogievskiy
No reasons for not reporting found corruptions as corruptions in case of some internal errors, especially in case of just failed to fix l2 entry (and in this case, missed corruptions may influence comparing logic, when we calculate difference between corruptions fields of two results)

Re: [Qemu-devel] [PATCH v5 5/5] qcow2-refcount: don't mask corruptions under internal errors

2019-02-27 Thread Max Reitz
On 27.02.19 14:14, Vladimir Sementsov-Ogievskiy wrote: > No reasons for not reporting found corruptions as corruptions in case > of some internal errors, especially in case of just failed to fix l2 > entry (and in this case, missed corruptions may influence comparing > logic, when we calculate