Re: [Qemu-devel] [PATCH v5 6/9] qemu-log: new option -dfilter to limit output

2016-02-10 Thread Alex Bennée
Richard Henderson writes: > On 02/05/2016 01:56 AM, Alex Bennée wrote: >> +gchar *range_op = g_strstr_len(r, -1, "-"); > > This is strchr. > >> +range_op = g_strstr_len(r, -1, "."); > > Or at least if you're going to make use of strstr, search for

Re: [Qemu-devel] [PATCH v5 6/9] qemu-log: new option -dfilter to limit output

2016-02-10 Thread Alex Bennée
Richard Henderson writes: > On 02/11/2016 04:40 AM, Alex Bennée wrote: >> OK I think this version is a lot cleaner: >> >>void qemu_set_dfilter_ranges(const char *filter_spec) >>{ >>gchar **ranges = g_strsplit(filter_spec, ",", 0); >>if (ranges) { >>

Re: [Qemu-devel] [PATCH v5 6/9] qemu-log: new option -dfilter to limit output

2016-02-10 Thread Richard Henderson
On 02/11/2016 04:40 AM, Alex Bennée wrote: OK I think this version is a lot cleaner: void qemu_set_dfilter_ranges(const char *filter_spec) { gchar **ranges = g_strsplit(filter_spec, ",", 0); if (ranges) { gchar **next = ranges; gchar *r = *next++;

Re: [Qemu-devel] [PATCH v5 6/9] qemu-log: new option -dfilter to limit output

2016-02-04 Thread Richard Henderson
On 02/05/2016 01:56 AM, Alex Bennée wrote: +gchar *range_op = g_strstr_len(r, -1, "-"); This is strchr. +range_op = g_strstr_len(r, -1, "."); Or at least if you're going to make use of strstr, search for "..". +g_strdelimit(range_val, ".", '

[Qemu-devel] [PATCH v5 6/9] qemu-log: new option -dfilter to limit output

2016-02-04 Thread Alex Bennée
When debugging big programs or system emulation sometimes you want both the verbosity of cpu,exec et all but don't want to generate lots of logs for unneeded stuff. This patch adds a new option -dfilter which allows you to specify interesting address ranges in the form: -dfilter