Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Cédric Le Goater
On 07/04/2016 02:11 PM, Peter Maydell wrote: > On 4 July 2016 at 13:01, Cédric Le Goater wrote: >> On 07/04/2016 01:14 PM, Peter Maydell wrote: >>> What is the test actually supposed to be doing? >>> writel() says "write this 32 bit value as if the (guest) CPU >>> wrote it to

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Peter Maydell
On 4 July 2016 at 13:01, Cédric Le Goater wrote: > On 07/04/2016 01:14 PM, Peter Maydell wrote: >> What is the test actually supposed to be doing? >> writel() says "write this 32 bit value as if the (guest) CPU >> wrote it to memory with a 32-bit write instruction". > > The test

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Cédric Le Goater
On 07/04/2016 01:14 PM, Peter Maydell wrote: > On 4 July 2016 at 10:15, Cédric Le Goater wrote: >> On 07/02/2016 08:05 PM, mar.krzeminski wrote: >>> >>> >>> W dniu 28.06.2016 o 20:24, Cédric Le Goater pisze: > +static void test_erase_sector(void) +{ +uint32_t

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Peter Maydell
On 4 July 2016 at 10:15, Cédric Le Goater wrote: > On 07/02/2016 08:05 PM, mar.krzeminski wrote: >> >> >> W dniu 28.06.2016 o 20:24, Cédric Le Goater pisze: >>> +static void test_erase_sector(void) >>> +{ >>> +uint32_t some_page_addr = 0x600 * PAGE_SIZE; >>> +uint32_t

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Cédric Le Goater
>>> +static void test_erase_sector(void) >>> +{ >>> +uint32_t some_page_addr = 0x600 * PAGE_SIZE; >>> +uint32_t page[PAGE_SIZE / 4]; >>> +int i; >>> + >>> +spi_conf(CONF_ENABLE_W0); >>> + >>> +spi_ctrl_start_user(); >>> +writeb(AST2400_FLASH_BASE, WREN); >>> +

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Cédric Le Goater
On 07/02/2016 08:05 PM, mar.krzeminski wrote: > > > W dniu 28.06.2016 o 20:24, Cédric Le Goater pisze: >> This test uses the palmetto platform and the AST2400 SPI controller to >> test the m25p80 flash module device model. The flash model is defined >> by the platform (n25q256a) and it would be

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-02 Thread mar.krzeminski
W dniu 28.06.2016 o 20:24, Cédric Le Goater pisze: This test uses the palmetto platform and the AST2400 SPI controller to test the m25p80 flash module device model. The flash model is defined by the platform (n25q256a) and it would be nice to find way to control it, using a property probably.

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-01 Thread Greg Kurz
On Fri, 1 Jul 2016 19:30:30 +0200 Cédric Le Goater wrote: > On 07/01/2016 07:18 PM, Peter Maydell wrote: > > On 28 June 2016 at 19:24, Cédric Le Goater wrote: > >> This test uses the palmetto platform and the AST2400 SPI controller to > >> test the m25p80 flash

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-01 Thread Peter Maydell
On 28 June 2016 at 19:24, Cédric Le Goater wrote: > This test uses the palmetto platform and the AST2400 SPI controller to > test the m25p80 flash module device model. The flash model is defined > by the platform (n25q256a) and it would be nice to find way to control > it, using a

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-01 Thread Cédric Le Goater
On 07/01/2016 07:18 PM, Peter Maydell wrote: > On 28 June 2016 at 19:24, Cédric Le Goater wrote: >> This test uses the palmetto platform and the AST2400 SPI controller to >> test the m25p80 flash module device model. The flash model is defined >> by the platform (n25q256a) and it

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-01 Thread Peter Maydell
On 1 July 2016 at 18:18, Peter Maydell wrote: > On 28 June 2016 at 19:24, Cédric Le Goater wrote: >> This test uses the palmetto platform and the AST2400 SPI controller to >> test the m25p80 flash module device model. The flash model is defined >> by the

[Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-06-28 Thread Cédric Le Goater
This test uses the palmetto platform and the AST2400 SPI controller to test the m25p80 flash module device model. The flash model is defined by the platform (n25q256a) and it would be nice to find way to control it, using a property probably. Signed-off-by: Cédric Le Goater